This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20568 ) Change subject: gprs_ns2: fix empty prefix in TLV Parse error ...................................................................... gprs_ns2: fix empty prefix in TLV Parse error Those messages were printed without any prefix because LOGPC was used. LOGPC means continue a log line. This must happened while copying this part of code over from ns1 where has been a LOGP in this function. Related: OS#4792 Change-Id: I2672ea0e34d19ea6172cb3458b8ff98d9700b2d0 --- M src/gb/gprs_ns2.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 7a15352..334989c 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -864,7 +864,7 @@ rc = ns2_tlv_parse(&tp, nsh->data+1, msgb_l2len(msg) - sizeof(*nsh)-1, 0, 0); if (rc < 0) { - LOGPC(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg)); + LOGP(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg)); return rc; } /* All sub-network service related message types */ @@ -878,7 +878,7 @@ rc = ns2_tlv_parse(&tp, nsh->data+5, msgb_l2len(msg) - sizeof(*nsh)-5, 0, 0); if (rc < 0) { - LOGPC(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg)); + LOGP(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg)); return rc; } tp.lv[NS_IE_NSEI].val = nsh->data+2; @@ -893,7 +893,7 @@ rc = ns2_tlv_parse(&tp, nsh->data, msgb_l2len(msg) - sizeof(*nsh), 0, 0); if (rc < 0) { - LOGPC(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg)); + LOGP(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg)); return rc; } /* All sub-network service related message types */ @@ -907,7 +907,7 @@ rc = ns2_tlv_parse(&tp, nsh->data, msgb_l2len(msg) - sizeof(*nsh), 0, 0); if (rc < 0) { - LOGPC(DLNS, LOGL_NOTICE, "Error during TLV Parse\n"); + LOGP(DLNS, LOGL_NOTICE, "Error during TLV Parse\n"); if (nsh->pdu_type != NS_PDUT_STATUS) ns2_tx_status(nsvc, NS_CAUSE_PROTO_ERR_UNSPEC, 0, msg); return rc; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2672ea0e34d19ea6172cb3458b8ff98d9700b2d0 Gerrit-Change-Number: 20568 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/0a4c477b/attachment.htm>