<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20568">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: fix empty prefix in TLV Parse error<br><br>Those messages were printed without any prefix because<br>LOGPC was used. LOGPC means continue a log line.<br>This must happened while copying this part of code over<br>from ns1 where has been a LOGP in this function.<br><br>Related: OS#4792<br>Change-Id: I2672ea0e34d19ea6172cb3458b8ff98d9700b2d0<br>---<br>M src/gb/gprs_ns2.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index 7a15352..334989c 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -864,7 +864,7 @@</span><br><span>            rc = ns2_tlv_parse(&tp, nsh->data+1,</span><br><span>                             msgb_l2len(msg) - sizeof(*nsh)-1, 0, 0);</span><br><span>          if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGPC(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGP(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg));</span><br><span>                      return rc;</span><br><span>           }</span><br><span>            /* All sub-network service related message types */</span><br><span>@@ -878,7 +878,7 @@</span><br><span>            rc = ns2_tlv_parse(&tp, nsh->data+5,</span><br><span>                             msgb_l2len(msg) - sizeof(*nsh)-5, 0, 0);</span><br><span>          if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGPC(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGP(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg));</span><br><span>                      return rc;</span><br><span>           }</span><br><span>            tp.lv[NS_IE_NSEI].val = nsh->data+2;</span><br><span>@@ -893,7 +893,7 @@</span><br><span>                rc = ns2_tlv_parse(&tp, nsh->data,</span><br><span>                               msgb_l2len(msg) - sizeof(*nsh), 0, 0);</span><br><span>            if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGPC(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+                      LOGP(DLNS, LOGL_NOTICE, "Error during TLV Parse in %s\n", msgb_hexdump(msg));</span><br><span>                      return rc;</span><br><span>           }</span><br><span>            /* All sub-network service related message types */</span><br><span>@@ -907,7 +907,7 @@</span><br><span>            rc = ns2_tlv_parse(&tp, nsh->data,</span><br><span>                               msgb_l2len(msg) - sizeof(*nsh), 0, 0);</span><br><span>            if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGPC(DLNS, LOGL_NOTICE, "Error during TLV Parse\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                       LOGP(DLNS, LOGL_NOTICE, "Error during TLV Parse\n");</span><br><span>                       if (nsh->pdu_type != NS_PDUT_STATUS)</span><br><span>                              ns2_tx_status(nsvc, NS_CAUSE_PROTO_ERR_UNSPEC, 0, msg);</span><br><span>                      return rc;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20568">change 20568</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20568"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2672ea0e34d19ea6172cb3458b8ff98d9700b2d0 </div>
<div style="display:none"> Gerrit-Change-Number: 20568 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>