Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Ensure BVC-RESET for BVCO=0 has no CellId IE

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20502 )

Change subject: BSSGP_Emulation: Ensure BVC-RESET for BVCO=0 has no CellId IE
......................................................................

BSSGP_Emulation: Ensure BVC-RESET for BVCO=0 has no CellId IE

This is required by the spec, and implemented libosmocore since
Change-Id Ie87820537d6d616da4fd4bbf73eab06e28fda5e1

So let's change our test expectations.  Meanwhile, introduce
mp_tolerate_bvc_reset_cellid for working around the bug in 'latest'.

Change-Id: If6245d73ed701e631b67146ace4ba028bdb4226c
---
M library/BSSGP_Emulation.ttcnpp
1 file changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp
index 931ff37..c1d297d 100644
--- a/library/BSSGP_Emulation.ttcnpp
+++ b/library/BSSGP_Emulation.ttcnpp
@@ -28,6 +28,12 @@
 
 import from SNDCP_Types all;
 
+
+modulepar {
+	/* tolerate CellID absence/presence in BVC-RESET in violation to spec */
+	boolean mp_tolerate_bvc_reset_cellid := false;
+}
+
 /***********************************************************************
  * Communication between Client Components and Main Component
  ***********************************************************************/
@@ -478,7 +484,13 @@
 	}
 
 	/* Respond to RESET for signalling BVCI 0 */
-	[] BSCP.receive(f_BnsUdInd(tr_BVC_RESET(?, 0, g_cfg.cell_id), 0)) -> value udi {
+	[] BSCP.receive(f_BnsUdInd(tr_BVC_RESET(?, 0, omit), 0)) -> value udi {
+		log("Rx BVC-RESET for Signaling BVCI=0");
+		f_send_bvc_reset_ack(0);
+	}
+
+	/* work-around for old, buggy libosmogb before Change-Id Ie87820537d6d616da4fd4bbf73eab06e28fda5e1 */
+	[mp_tolerate_bvc_reset_cellid] BSCP.receive(f_BnsUdInd(tr_BVC_RESET(?, 0, g_cfg.cell_id), 0)) -> value udi {
 		log("Rx BVC-RESET for Signaling BVCI=0");
 		f_send_bvc_reset_ack(0);
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20502
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If6245d73ed701e631b67146ace4ba028bdb4226c
Gerrit-Change-Number: 20502
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201009/5152f99b/attachment.htm>