<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20502">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSSGP_Emulation: Ensure BVC-RESET for BVCO=0 has no CellId IE<br><br>This is required by the spec, and implemented libosmocore since<br>Change-Id Ie87820537d6d616da4fd4bbf73eab06e28fda5e1<br><br>So let's change our test expectations.  Meanwhile, introduce<br>mp_tolerate_bvc_reset_cellid for working around the bug in 'latest'.<br><br>Change-Id: If6245d73ed701e631b67146ace4ba028bdb4226c<br>---<br>M library/BSSGP_Emulation.ttcnpp<br>1 file changed, 13 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp</span><br><span>index 931ff37..c1d297d 100644</span><br><span>--- a/library/BSSGP_Emulation.ttcnpp</span><br><span>+++ b/library/BSSGP_Emulation.ttcnpp</span><br><span>@@ -28,6 +28,12 @@</span><br><span> </span><br><span> import from SNDCP_Types all;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+modulepar {</span><br><span style="color: hsl(120, 100%, 40%);">+     /* tolerate CellID absence/presence in BVC-RESET in violation to spec */</span><br><span style="color: hsl(120, 100%, 40%);">+      boolean mp_tolerate_bvc_reset_cellid := false;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /***********************************************************************</span><br><span>  * Communication between Client Components and Main Component</span><br><span>  ***********************************************************************/</span><br><span>@@ -478,7 +484,13 @@</span><br><span>         }</span><br><span> </span><br><span>        /* Respond to RESET for signalling BVCI 0 */</span><br><span style="color: hsl(0, 100%, 40%);">-    [] BSCP.receive(f_BnsUdInd(tr_BVC_RESET(?, 0, g_cfg.cell_id), 0)) -> value udi {</span><br><span style="color: hsl(120, 100%, 40%);">+   [] BSCP.receive(f_BnsUdInd(tr_BVC_RESET(?, 0, omit), 0)) -> value udi {</span><br><span style="color: hsl(120, 100%, 40%);">+            log("Rx BVC-RESET for Signaling BVCI=0");</span><br><span style="color: hsl(120, 100%, 40%);">+           f_send_bvc_reset_ack(0);</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   /* work-around for old, buggy libosmogb before Change-Id Ie87820537d6d616da4fd4bbf73eab06e28fda5e1 */</span><br><span style="color: hsl(120, 100%, 40%);">+ [mp_tolerate_bvc_reset_cellid] BSCP.receive(f_BnsUdInd(tr_BVC_RESET(?, 0, g_cfg.cell_id), 0)) -> value udi {</span><br><span>              log("Rx BVC-RESET for Signaling BVCI=0");</span><br><span>          f_send_bvc_reset_ack(0);</span><br><span>     }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20502">change 20502</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20502"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If6245d73ed701e631b67146ace4ba028bdb4226c </div>
<div style="display:none"> Gerrit-Change-Number: 20502 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>