Change in libosmocore[master]: logging: Change stderr + file target to use non-blocking write

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Oct 8 16:40:35 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20296 )

Change subject: logging: Change stderr + file target to use non-blocking write
......................................................................


Patch Set 10:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/20296/9/src/vty/logging_vty.c 
File src/vty/logging_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/20296/9/src/vty/logging_vty.c@764 
PS9, Line 764: 	"log stderr [blocking-io]",
> So having the blocking-io option here it means to switch from one buffering method to another one ne […]
the "log" node is sharead among all targets, if I install an additional node it would also be present for gsmtap, etc. - which is confusing.

I don't think it's a big problem to close + reopen a file once during startup or config file change.


https://gerrit.osmocom.org/c/libosmocore/+/20296/9/src/vty/logging_vty.c@921 
PS9, Line 921: 			vty_out(vty, "log stderr%s", VTY_NEWLINE);
> vty_out(vty, "log stderr%s%s", […]
I prefer the the more vebose approach over longer ternary-operator lines.  Here it's still ok, but in the 'log file' below, it would  be too long for my taste.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20296
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia58fd78535c41b3da3aeb7733aadc785ace610da
Gerrit-Change-Number: 20296
Gerrit-PatchSet: 10
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Oct 2020 16:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201008/442891ae/attachment.htm>


More information about the gerrit-log mailing list