Change in libosmocore[master]: logging: Change stderr + file target to use non-blocking write

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20296 )

Change subject: logging: Change stderr + file target to use non-blocking write
......................................................................


Patch Set 10: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/20296/9/src/vty/logging_vty.c 
File src/vty/logging_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/20296/9/src/vty/logging_vty.c@764 
PS9, Line 764: 	"log stderr [blocking-io]",
So having the blocking-io option here it means to switch from one buffering method to another one needs to destroy and recreate the entire target.
Since anyway the function log_target_*_switch_to_* exist, it may more sense to have this option as a separate VTY command?


https://gerrit.osmocom.org/c/libosmocore/+/20296/9/src/vty/logging_vty.c@921 
PS9, Line 921: 			vty_out(vty, "log stderr%s", VTY_NEWLINE);
vty_out(vty, "log stderr%s%s",
        tgt->tgt_file.wqueue ? : "" : " blocking-io", VTY_NEWLINE);



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20296
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia58fd78535c41b3da3aeb7733aadc785ace610da
Gerrit-Change-Number: 20296
Gerrit-PatchSet: 10
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Oct 2020 16:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201008/836bd175/attachment.htm>