Change in libosmocore[master]: gprs_ns2_vty_create: remove bind pointer check

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20467 )

Change subject: gprs_ns2_vty_create: remove bind pointer check
......................................................................

gprs_ns2_vty_create: remove bind pointer check

The bind pointer can't be NULL because gprs_ns2_ip_bind()
is either return 0 and bind is valid or != 0 and returning.

Found-by: Coverity
Fixes: CID#214854
Change-Id: I11d86c9cb36226701e51942f14d7a6412c3eff26
---
M src/gb/gprs_ns2_vty.c
1 file changed, 8 insertions(+), 10 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c
index 01eb534..c6c4b02 100644
--- a/src/gb/gprs_ns2_vty.c
+++ b/src/gb/gprs_ns2_vty.c
@@ -810,17 +810,15 @@
 		}
 		nse->persistent = true;
 
-		if (bind) {
-			nsvc = gprs_ns2_ip_connect(bind,
-						   &sockaddr,
-						   nse,
-						   vtyvc->nsvci);
-			if (!nsvc) {
-				/* Could not create NSVC, connect failed */
-				continue;
-			}
-			nsvc->persistent = true;
+		nsvc = gprs_ns2_ip_connect(bind,
+					   &sockaddr,
+					   nse,
+					   vtyvc->nsvci);
+		if (!nsvc) {
+			/* Could not create NSVC, connect failed */
+			continue;
 		}
+		nsvc->persistent = true;
 	}
 
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20467
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I11d86c9cb36226701e51942f14d7a6412c3eff26
Gerrit-Change-Number: 20467
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201007/36c9c467/attachment.htm>