<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20467">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_vty_create: remove bind pointer check<br><br>The bind pointer can't be NULL because gprs_ns2_ip_bind()<br>is either return 0 and bind is valid or != 0 and returning.<br><br>Found-by: Coverity<br>Fixes: CID#214854<br>Change-Id: I11d86c9cb36226701e51942f14d7a6412c3eff26<br>---<br>M src/gb/gprs_ns2_vty.c<br>1 file changed, 8 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c</span><br><span>index 01eb534..c6c4b02 100644</span><br><span>--- a/src/gb/gprs_ns2_vty.c</span><br><span>+++ b/src/gb/gprs_ns2_vty.c</span><br><span>@@ -810,17 +810,15 @@</span><br><span>                }</span><br><span>            nse->persistent = true;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          if (bind) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     nsvc = gprs_ns2_ip_connect(bind,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                   &sockaddr,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                  nse,</span><br><span style="color: hsl(0, 100%, 40%);">-                                            vtyvc->nsvci);</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (!nsvc) {</span><br><span style="color: hsl(0, 100%, 40%);">-                            /* Could not create NSVC, connect failed */</span><br><span style="color: hsl(0, 100%, 40%);">-                             continue;</span><br><span style="color: hsl(0, 100%, 40%);">-                       }</span><br><span style="color: hsl(0, 100%, 40%);">-                       nsvc->persistent = true;</span><br><span style="color: hsl(120, 100%, 40%);">+           nsvc = gprs_ns2_ip_connect(bind,</span><br><span style="color: hsl(120, 100%, 40%);">+                                         &sockaddr,</span><br><span style="color: hsl(120, 100%, 40%);">+                                        nse,</span><br><span style="color: hsl(120, 100%, 40%);">+                                          vtyvc->nsvci);</span><br><span style="color: hsl(120, 100%, 40%);">+          if (!nsvc) {</span><br><span style="color: hsl(120, 100%, 40%);">+                  /* Could not create NSVC, connect failed */</span><br><span style="color: hsl(120, 100%, 40%);">+                   continue;</span><br><span>            }</span><br><span style="color: hsl(120, 100%, 40%);">+             nsvc->persistent = true;</span><br><span>  }</span><br><span> </span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20467">change 20467</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20467"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I11d86c9cb36226701e51942f14d7a6412c3eff26 </div>
<div style="display:none"> Gerrit-Change-Number: 20467 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>