Change in libosmo-abis[master]: vty: use install_lib_element() and install_lib_element_ve()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Oct 6 12:22:03 UTC 2020


Vadim Yanitskiy has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/20443 )

Change subject: vty: use install_lib_element() and install_lib_element_ve()
......................................................................

vty: use install_lib_element() and install_lib_element_ve()

See https://lists.osmocom.org/pipermail/openbsc/2020-October/013278.html.

Change-Id: I22a8075852ba97edf819b368e3af4eddbf1dbae0
Depends: I8baf31ace93c536421893c2aa4e3d9d298dcbcc6
Related: SYS#4937
---
M src/e1_input_vty.c
M src/ipa_proxy.c
2 files changed, 25 insertions(+), 25 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/e1_input_vty.c b/src/e1_input_vty.c
index 0da1bc5..2dc873f 100644
--- a/src/e1_input_vty.c
+++ b/src/e1_input_vty.c
@@ -462,27 +462,27 @@
 
 int e1inp_vty_init(void)
 {
-	install_element(CONFIG_NODE, &cfg_e1inp_cmd);
+	install_lib_element(CONFIG_NODE, &cfg_e1inp_cmd);
 	install_node(&e1inp_node, e1inp_config_write);
 
-	install_element(L_E1INP_NODE, &cfg_e1_pcap_cmd);
-	install_element(L_E1INP_NODE, &cfg_e1_no_pcap_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_pcap_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_no_pcap_cmd);
 
-	install_element(L_E1INP_NODE, &cfg_e1_line_driver_cmd);
-	install_element(L_E1INP_NODE, &cfg_e1_line_port_cmd);
-	install_element(L_E1INP_NODE, &cfg_e1_line_socket_cmd);
-	install_element(L_E1INP_NODE, &cfg_e1_line_name_cmd);
-	install_element(L_E1INP_NODE, &cfg_e1_line_keepalive_cmd);
-	install_element(L_E1INP_NODE, &cfg_e1_line_keepalive_params_cmd);
-	install_element(L_E1INP_NODE, &cfg_e1_line_no_keepalive_cmd);
-	install_element(L_E1INP_NODE, &cfg_e1_line_ipa_keepalive_cmd);
-	install_element(L_E1INP_NODE, &cfg_e1_line_no_ipa_keepalive_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_line_driver_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_line_port_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_line_socket_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_line_name_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_line_keepalive_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_line_keepalive_params_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_line_no_keepalive_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_line_ipa_keepalive_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_e1_line_no_ipa_keepalive_cmd);
 
-	install_element(L_E1INP_NODE, &cfg_ipa_bind_cmd);
+	install_lib_element(L_E1INP_NODE, &cfg_ipa_bind_cmd);
 
-	install_element_ve(&show_e1drv_cmd);
-	install_element_ve(&show_e1line_cmd);
-	install_element_ve(&show_e1ts_cmd);
+	install_lib_element_ve(&show_e1drv_cmd);
+	install_lib_element_ve(&show_e1line_cmd);
+	install_lib_element_ve(&show_e1ts_cmd);
 
 	return 0;
 }
diff --git a/src/ipa_proxy.c b/src/ipa_proxy.c
index 980add7..441dd3f 100644
--- a/src/ipa_proxy.c
+++ b/src/ipa_proxy.c
@@ -643,15 +643,15 @@
 	tall_ipa_proxy_ctx =
 		talloc_named_const(libosmo_abis_ctx, 1, "ipa_proxy");
 
-	install_element(ENABLE_NODE, &ipa_instance_add_cmd);
-	install_element(ENABLE_NODE, &ipa_instance_del_cmd);
-	install_element(ENABLE_NODE, &ipa_instance_show_cmd);
-	install_element(ENABLE_NODE, &ipa_route_add_cmd);
-	install_element(ENABLE_NODE, &ipa_route_del_cmd);
-	install_element(ENABLE_NODE, &ipa_route_show_cmd);
+	install_lib_element(ENABLE_NODE, &ipa_instance_add_cmd);
+	install_lib_element(ENABLE_NODE, &ipa_instance_del_cmd);
+	install_lib_element(ENABLE_NODE, &ipa_instance_show_cmd);
+	install_lib_element(ENABLE_NODE, &ipa_route_add_cmd);
+	install_lib_element(ENABLE_NODE, &ipa_route_del_cmd);
+	install_lib_element(ENABLE_NODE, &ipa_route_show_cmd);
 
-	install_element(CONFIG_NODE, &ipa_cfg_cmd);
+	install_lib_element(CONFIG_NODE, &ipa_cfg_cmd);
 	install_node(&ipa_node, ipa_cfg_write);
-	install_element(L_IPA_NODE, &ipa_instance_cfg_add_cmd);
-	install_element(L_IPA_NODE, &ipa_route_cfg_add_cmd);
+	install_lib_element(L_IPA_NODE, &ipa_instance_cfg_add_cmd);
+	install_lib_element(L_IPA_NODE, &ipa_route_cfg_add_cmd);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/20443
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I22a8075852ba97edf819b368e3af4eddbf1dbae0
Gerrit-Change-Number: 20443
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201006/d4933f05/attachment.htm>


More information about the gerrit-log mailing list