<p>Vadim Yanitskiy <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/20443">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: use install_lib_element() and install_lib_element_ve()<br><br>See https://lists.osmocom.org/pipermail/openbsc/2020-October/013278.html.<br><br>Change-Id: I22a8075852ba97edf819b368e3af4eddbf1dbae0<br>Depends: I8baf31ace93c536421893c2aa4e3d9d298dcbcc6<br>Related: SYS#4937<br>---<br>M src/e1_input_vty.c<br>M src/ipa_proxy.c<br>2 files changed, 25 insertions(+), 25 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/e1_input_vty.c b/src/e1_input_vty.c</span><br><span>index 0da1bc5..2dc873f 100644</span><br><span>--- a/src/e1_input_vty.c</span><br><span>+++ b/src/e1_input_vty.c</span><br><span>@@ -462,27 +462,27 @@</span><br><span> </span><br><span> int e1inp_vty_init(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    install_element(CONFIG_NODE, &cfg_e1inp_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+     install_lib_element(CONFIG_NODE, &cfg_e1inp_cmd);</span><br><span>        install_node(&e1inp_node, e1inp_config_write);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  install_element(L_E1INP_NODE, &cfg_e1_pcap_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-    install_element(L_E1INP_NODE, &cfg_e1_no_pcap_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+       install_lib_element(L_E1INP_NODE, &cfg_e1_pcap_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+      install_lib_element(L_E1INP_NODE, &cfg_e1_no_pcap_cmd);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- install_element(L_E1INP_NODE, &cfg_e1_line_driver_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-     install_element(L_E1INP_NODE, &cfg_e1_line_port_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-       install_element(L_E1INP_NODE, &cfg_e1_line_socket_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-     install_element(L_E1INP_NODE, &cfg_e1_line_name_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-       install_element(L_E1INP_NODE, &cfg_e1_line_keepalive_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-  install_element(L_E1INP_NODE, &cfg_e1_line_keepalive_params_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-   install_element(L_E1INP_NODE, &cfg_e1_line_no_keepalive_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-       install_element(L_E1INP_NODE, &cfg_e1_line_ipa_keepalive_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-      install_element(L_E1INP_NODE, &cfg_e1_line_no_ipa_keepalive_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_lib_element(L_E1INP_NODE, &cfg_e1_line_driver_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+       install_lib_element(L_E1INP_NODE, &cfg_e1_line_port_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_lib_element(L_E1INP_NODE, &cfg_e1_line_socket_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+       install_lib_element(L_E1INP_NODE, &cfg_e1_line_name_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_lib_element(L_E1INP_NODE, &cfg_e1_line_keepalive_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+    install_lib_element(L_E1INP_NODE, &cfg_e1_line_keepalive_params_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+     install_lib_element(L_E1INP_NODE, &cfg_e1_line_no_keepalive_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_lib_element(L_E1INP_NODE, &cfg_e1_line_ipa_keepalive_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+        install_lib_element(L_E1INP_NODE, &cfg_e1_line_no_ipa_keepalive_cmd);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   install_element(L_E1INP_NODE, &cfg_ipa_bind_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_lib_element(L_E1INP_NODE, &cfg_ipa_bind_cmd);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   install_element_ve(&show_e1drv_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-        install_element_ve(&show_e1line_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-       install_element_ve(&show_e1ts_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+       install_lib_element_ve(&show_e1drv_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+  install_lib_element_ve(&show_e1line_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_lib_element_ve(&show_e1ts_cmd);</span><br><span> </span><br><span>      return 0;</span><br><span> }</span><br><span>diff --git a/src/ipa_proxy.c b/src/ipa_proxy.c</span><br><span>index 980add7..441dd3f 100644</span><br><span>--- a/src/ipa_proxy.c</span><br><span>+++ b/src/ipa_proxy.c</span><br><span>@@ -643,15 +643,15 @@</span><br><span>      tall_ipa_proxy_ctx =</span><br><span>                 talloc_named_const(libosmo_abis_ctx, 1, "ipa_proxy");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     install_element(ENABLE_NODE, &ipa_instance_add_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-        install_element(ENABLE_NODE, &ipa_instance_del_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-        install_element(ENABLE_NODE, &ipa_instance_show_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-       install_element(ENABLE_NODE, &ipa_route_add_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-   install_element(ENABLE_NODE, &ipa_route_del_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-   install_element(ENABLE_NODE, &ipa_route_show_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+        install_lib_element(ENABLE_NODE, &ipa_instance_add_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+  install_lib_element(ENABLE_NODE, &ipa_instance_del_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+  install_lib_element(ENABLE_NODE, &ipa_instance_show_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_lib_element(ENABLE_NODE, &ipa_route_add_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+     install_lib_element(ENABLE_NODE, &ipa_route_del_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+     install_lib_element(ENABLE_NODE, &ipa_route_show_cmd);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  install_element(CONFIG_NODE, &ipa_cfg_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+       install_lib_element(CONFIG_NODE, &ipa_cfg_cmd);</span><br><span>  install_node(&ipa_node, ipa_cfg_write);</span><br><span style="color: hsl(0, 100%, 40%);">-     install_element(L_IPA_NODE, &ipa_instance_cfg_add_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">-     install_element(L_IPA_NODE, &ipa_route_cfg_add_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+      install_lib_element(L_IPA_NODE, &ipa_instance_cfg_add_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+       install_lib_element(L_IPA_NODE, &ipa_route_cfg_add_cmd);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/20443">change 20443</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/20443"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I22a8075852ba97edf819b368e3af4eddbf1dbae0 </div>
<div style="display:none"> Gerrit-Change-Number: 20443 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>