Change in osmo-bts[master]: Introduce NM Radio Carrier and Baseband Transceiver FSMs

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20284 )

Change subject: Introduce NM Radio Carrier and Baseband Transceiver FSMs
......................................................................


Patch Set 9:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/include/osmo-bts/bts_trx.h 
File include/osmo-bts/bts_trx.h:

https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/include/osmo-bts/bts_trx.h@9 
PS9, Line 9: _mo mo;
           : };
another instance of moving fsm_inst + opstart_success into gsm_abis_mo :P


https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/include/osmo-bts/nm_bb_transc_fsm.h 
File include/osmo-bts/nm_bb_transc_fsm.h:

https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/include/osmo-bts/nm_bb_transc_fsm.h@35 
PS9, Line 35: NM_BBTRANSC_EV_SW_ACT,
            : 	NM_BBTRANSC_EV_OPSTART_ACK,
            : 	NM_BBTRANSC_EV_OPSTART_NACK,
and again some events that could be shared.


https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/src/osmo-bts-litecell15/oml.c 
File src/osmo-bts-litecell15/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/src/osmo-bts-litecell15/oml.c@1895 
PS9, Line 1895: 	rc = osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_OPSTART_ACK, NULL);
              : 		break;
              : 	case NM_OC_BTS:
              : 		rc = osmo_fsm_inst_dispatch(bts->nm.fi, NM_BTS_EV_OPSTART_ACK, NULL);
              : 		break;
              : 	case NM_OC_RADIO_CARRIER:
              : 		trx = (struct gsm_bts_trx *) obj;
              : 		rc = trx_init(trx);
              : 		break;
              : 	case NM_OC_BASEB_TRANSC:
              : 		trx = (struct gsm_bts_trx *) obj;
              : 		rc = osmo_fsm_inst_dispatch(trx->bb_transc.fi, NM_BBTRANSC_EV_OPSTART_ACK, NULL);
those could all be receiving the same event.  In the end, I would consider the FSM [instance] to be a "private implementation detail" of the gsm_abis_mo.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20284
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifb249a821c4270918699b6375a72b3a618e8cfbe
Gerrit-Change-Number: 20284
Gerrit-PatchSet: 9
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 02 Oct 2020 21:48:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201002/d26c9d63/attachment.htm>