<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20284">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/include/osmo-bts/bts_trx.h">File include/osmo-bts/bts_trx.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/include/osmo-bts/bts_trx.h@9">Patch Set #9, Line 9:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">_mo mo;<br>};<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">another instance of moving fsm_inst + opstart_success into gsm_abis_mo :P</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/include/osmo-bts/nm_bb_transc_fsm.h">File include/osmo-bts/nm_bb_transc_fsm.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/include/osmo-bts/nm_bb_transc_fsm.h@35">Patch Set #9, Line 35:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">NM_BBTRANSC_EV_SW_ACT,<br>        NM_BBTRANSC_EV_OPSTART_ACK,<br>   NM_BBTRANSC_EV_OPSTART_NACK,<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">and again some events that could be shared.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/src/osmo-bts-litecell15/oml.c">File src/osmo-bts-litecell15/oml.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/20284/9/src/osmo-bts-litecell15/oml.c@1895">Patch Set #9, Line 1895:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       rc = osmo_fsm_inst_dispatch(bts->site_mgr.fi, NM_BTS_SM_EV_OPSTART_ACK, NULL);<br>             break;<br>        case NM_OC_BTS:<br>               rc = osmo_fsm_inst_dispatch(bts->nm.fi, NM_BTS_EV_OPSTART_ACK, NULL);<br>              break;<br>        case NM_OC_RADIO_CARRIER:<br>             trx = (struct gsm_bts_trx *) obj;<br>             rc = trx_init(trx);<br>           break;<br>        case NM_OC_BASEB_TRANSC:<br>              trx = (struct gsm_bts_trx *) obj;<br>             rc = osmo_fsm_inst_dispatch(trx->bb_transc.fi, NM_BBTRANSC_EV_OPSTART_ACK, NULL);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">those could all be receiving the same event.  In the end, I would consider the FSM [instance] to be a "private implementation detail" of the gsm_abis_mo.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/20284">change 20284</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/20284"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifb249a821c4270918699b6375a72b3a618e8cfbe </div>
<div style="display:none"> Gerrit-Change-Number: 20284 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 02 Oct 2020 21:48:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>