Change in osmo-bsc[master]: LCS: SCCP next conn id: prepare Lb-interface

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Oct 1 14:35:15 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20356 )

Change subject: LCS: SCCP next conn id: prepare Lb-interface
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/include/osmocom/bsc/gsm_data.h@53 
PS1, Line 53: struct osmo_sccp_instance;
> Add header of dependancy library instead.
no, we discussed before. you should talk to some OpenBSD guys once in a while :)


https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/src/osmo-bsc/bsc_sccp.c 
File src/osmo-bsc/bsc_sccp.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/src/osmo-bsc/bsc_sccp.c@36 
PS1, Line 36: 	for (i = 0; i < 0xFFFFFF; i++) {
> you use a uint32_t but check against 8*3=24 bits? is this wrong? please document otherwise where doe […]
yea not sure about that, apparently SCCP conn ids are 24 bit. adopted that from earlier code


https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/src/osmo-bsc/bsc_sccp.c@43 
PS1, Line 43: 			if (conn->sccp.msc && conn->sccp.msc->a.sccp == sccp) {
> does it need to be uniqe per MSC? or for all MSCs?
for *all* SCCP connections across all SSNs, so not only all MSCs but also the Lb interface.
(But limited per cs7 instance.)


https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/src/osmo-bsc/bsc_sccp.c@45 
PS1, Line 45: 					conn_id_already_used = true;
> Shouldn't you try harder here? by incrementing next_id again until a whole loop is done. […]
believe me i cracked my head and it's a hard problem. in the end i realized: in practice this will be quite optimal because by the time we wrap back to a zero conn_id, those old ones will have long become unused, so we will simply iterate once on all conns just to be sure it is really unused.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20356
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I12fcb18f6e4380f72929cfe7681bac05330a8c9a
Gerrit-Change-Number: 20356
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 14:35:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/195b9190/attachment.htm>


More information about the gerrit-log mailing list