Change in osmo-bsc[master]: LCS: SCCP next conn id: prepare Lb-interface

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20356 )

Change subject: LCS: SCCP next conn id: prepare Lb-interface
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/include/osmocom/bsc/gsm_data.h@53 
PS1, Line 53: struct osmo_sccp_instance;
Add header of dependancy library instead.


https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/src/osmo-bsc/bsc_sccp.c 
File src/osmo-bsc/bsc_sccp.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/src/osmo-bsc/bsc_sccp.c@28 
PS1, Line 28: int bsc_sccp_inst_next_conn_id(struct osmo_sccp_instance *sccp)
Header file for "struct osmo_sccp_instance" missing.


https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/src/osmo-bsc/bsc_sccp.c@36 
PS1, Line 36: 	for (i = 0; i < 0xFFFFFF; i++) {
you use a uint32_t but check against 8*3=24 bits? is this wrong? please document otherwise where does this value come from, and if possible use a define.


https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/src/osmo-bsc/bsc_sccp.c@43 
PS1, Line 43: 			if (conn->sccp.msc && conn->sccp.msc->a.sccp == sccp) {
does it need to be uniqe per MSC? or for all MSCs?


https://gerrit.osmocom.org/c/osmo-bsc/+/20356/1/src/osmo-bsc/bsc_sccp.c@45 
PS1, Line 45: 					conn_id_already_used = true;
Shouldn't you try harder here? by incrementing next_id again until a whole loop is done.
You could optimize with a bit mask on a bitvec perhaps, or an rb_tree/hashtable.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20356
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I12fcb18f6e4380f72929cfe7681bac05330a8c9a
Gerrit-Change-Number: 20356
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 11:12:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/10442bd1/attachment.htm>