Change in osmo-bsc[master]: LCS: implement the bulk of Location Services

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 )

Change subject: LCS: implement the bulk of Location Services
......................................................................


Patch Set 1:

(7 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h 
File include/osmocom/bsc/lcs_loc_req.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h@8 
PS1, Line 8: 		LOGPFSML(LOC_REQ->fi, level, fmt, ## args); \
missing () around LOC_REQ


https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h 
File include/osmocom/bsc/lcs_ta_req.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h@11 
PS1, Line 11: 		LOGPFSML(TA_REQ->fi, level, fmt, ## args); \
()


https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c 
File src/osmo-bsc/lb.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@49 
PS1, Line 49: 	// TODO use
what about this?


https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@653 
PS1, Line 653: 	"serving mobile location centre",
caps at start of word?


https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c 
File src/osmo-bsc/lcs_loc_req.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c@144 
PS1, Line 144: 	// FIXME LCS QoS IE is mandatory for requesting the location
This probably needs to be addressed before merging?


https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_ta_req.c 
File src/osmo-bsc/lcs_ta_req.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_ta_req.c@207 
PS1, Line 207: 	bsslap_ta_resp = (struct osmo_bssap_le_pdu) {
lol


https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c 
File src/osmo-bsc/paging.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c@461 
PS1, Line 461: int paging_request_cancel(struct bsc_subscr *bsub, enum bsc_paging_reason reasons)
unsigned



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872
Gerrit-Change-Number: 20357
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 11:53:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/2785ebec/attachment.htm>