<p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h">File include/osmocom/bsc/lcs_loc_req.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h@8">Patch Set #1, Line 8:</a> <code style="font-family:monospace,monospace">            LOGPFSML(LOC_REQ->fi, level, fmt, ## args); \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">missing () around LOC_REQ</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h">File include/osmocom/bsc/lcs_ta_req.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h@11">Patch Set #1, Line 11:</a> <code style="font-family:monospace,monospace">         LOGPFSML(TA_REQ->fi, level, fmt, ## args); \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">()</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c">File src/osmo-bsc/lb.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@49">Patch Set #1, Line 49:</a> <code style="font-family:monospace,monospace">      // TODO use</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">what about this?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@653">Patch Set #1, Line 653:</a> <code style="font-family:monospace,monospace">     "serving mobile location centre",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">caps at start of word?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c">File src/osmo-bsc/lcs_loc_req.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_loc_req.c@144">Patch Set #1, Line 144:</a> <code style="font-family:monospace,monospace"> // FIXME LCS QoS IE is mandatory for requesting the location</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This probably needs to be addressed before merging?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_ta_req.c">File src/osmo-bsc/lcs_ta_req.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lcs_ta_req.c@207">Patch Set #1, Line 207:</a> <code style="font-family:monospace,monospace">      bsslap_ta_resp = (struct osmo_bssap_le_pdu) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">lol</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c">File src/osmo-bsc/paging.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/paging.c@461">Patch Set #1, Line 461:</a> <code style="font-family:monospace,monospace">int paging_request_cancel(struct bsc_subscr *bsub, enum bsc_paging_reason reasons)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unsigned</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357">change 20357</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20357"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 </div>
<div style="display:none"> Gerrit-Change-Number: 20357 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 01 Oct 2020 11:53:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>