Change in libosmocore[master]: add BSSLAP coding for Location Services

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20333 )

Change subject: add BSSLAP coding for Location Services
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/20333/1/include/osmocom/gsm/bsslap.h 
File include/osmocom/gsm/bsslap.h:

https://gerrit.osmocom.org/c/libosmocore/+/20333/1/include/osmocom/gsm/bsslap.h@37 
PS1, Line 37: enum osmo_bsslap_msgt {
are those defintiions from the protocol spec, or are they osmocom specific?

If they are from a 3gpp spec, we
* put the definition to osmocom/gsm/protocol/*.h
* typically don't use a OSMO_ prefix
* are preceded by a comment with a reference to the specific section of the relevant specification

If they are osmocom-api-specific definitions, theyare in include/osmocom/gsm/*.h like this file is


https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c 
File src/gsm/bsslap.c:

https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c@38 
PS1, Line 38: 	OSMO_BSSLAP_IEI_TA = 0x1,
those look like 3GPP constants? see my earlier comment.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20333
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6409c4bcac402dc7626a3afce9081c59cd715fe8
Gerrit-Change-Number: 20333
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 01 Oct 2020 10:03:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/96613fb2/attachment.htm>