<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20333">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20333/1/include/osmocom/gsm/bsslap.h">File include/osmocom/gsm/bsslap.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/20333/1/include/osmocom/gsm/bsslap.h@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace">enum osmo_bsslap_msgt {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">are those defintiions from the protocol spec, or are they osmocom specific?</p><p style="white-space: pre-wrap; word-wrap: break-word;">If they are from a 3gpp spec, we</p><ul><li>put the definition to osmocom/gsm/protocol/*.h</li><li>typically don't use a OSMO_ prefix</li><li>are preceded by a comment with a reference to the specific section of the relevant specification</li></ul><p style="white-space: pre-wrap; word-wrap: break-word;">If they are osmocom-api-specific definitions, theyare in include/osmocom/gsm/*.h like this file is</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c">File src/gsm/bsslap.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c@38">Patch Set #1, Line 38:</a> <code style="font-family:monospace,monospace">  OSMO_BSSLAP_IEI_TA = 0x1,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">those look like 3GPP constants? see my earlier comment.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/20333">change 20333</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/20333"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6409c4bcac402dc7626a3afce9081c59cd715fe8 </div>
<div style="display:none"> Gerrit-Change-Number: 20333 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 01 Oct 2020 10:03:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>