This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21185 )
Change subject: l1sap: add repeated uplink SACCH
......................................................................
Patch Set 5:
(8 comments)
(ensure all comments are sent)
https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/common/l1sap.c
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/common/l1sap.c@1420
PS4, Line 1420: switch (lchan->repeated_acch_capability.rxqual) {
: case 1:
: upper = 26;
: lower = 10;
: break;
: case 2:
: upper = 51;
: lower = 10;
: break;
: case 3:
: upper = 100;
: lower = 30;
: break;
: case 4:
: upper = 190;
: lower = 64;
: break;
: case 5:
: upper = 380;
: lower = 130;
: break;
: case 6:
: upper = 760;
: lower = 270;
: break;
: case 7:
: upper = 1500;
: lower = 540;
: break;
: }
> can we simply implement that by a single table lookup (i. […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c
File src/osmo-bts-trx/sched_lchan_xcch.c:
https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@63
PS3, Line 63: repeated_ul_sacch_active_decision
> Not sure if this file (which is more about mapping, interleaving, and convolutional coding) is the r […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@101
PS3, Line 101: talloc_zero_size
> Not really related, but I think we should move memory allocations out of the burst handlers. […]
Makes sense, but would that increase the performance that much? Allocation happens only once, only the check happens every time - but this does not have to be that way either.
https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@111
PS3, Line 111: *chan_state->ul_bursts_prev
> This is wrong, and may lead to NULL-pointer dereference if talloc returns NULL. CR-1.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@178
PS3, Line 178: LOGL_NOTICE
> Not sure if this event actually deserves NOTICE. I would drop this logging statement.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@179
PS3, Line 179: also yields good data
> ... and this reads really weird. […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@192
PS3, Line 192: L1SAP_IS_LINK_SACCH(trx_chan_desc[chan].link_id) && lchan->repeated_ul_sacch_active
> I think it makes sense to pre-calculate this condition into a boolean variable, given that you're us […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/osmo-bts-trx/sched_lchan_xcch.c
File src/osmo-bts-trx/sched_lchan_xcch.c:
https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/osmo-bts-trx/sched_lchan_xcch.c@37
PS4, Line 37: /* Add two arrays of sbits */
: static void add_sbits(sbit_t *current, const sbit_t *previous)
> so this is a saturated addition implementation. […]
I have moved over to the averaged approach. In my experiments I could see that the bit error rate of decoded blocks is slightly increased, but only in the order of one bit of course. I would say there is no difference.
Its probably better to defer this to TNT as I do not know either what the best way is. What I can say is that this method indeed worked, but there may be other methods with better performance of course.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac
Gerrit-Change-Number: 21185
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 28 Nov 2020 21:45:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201128/44d99afe/attachment.htm>