<p style="white-space: pre-wrap; word-wrap: break-word;">(ensure all comments are sent)</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185">View Change</a></p><p>8 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/common/l1sap.c">File src/common/l1sap.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/common/l1sap.c@1420">Patch Set #4, Line 1420:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">switch (lchan->repeated_acch_capability.rxqual) {<br> case 1:<br> upper = 26;<br> lower = 10;<br> break;<br> case 2:<br> upper = 51;<br> lower = 10;<br> break;<br> case 3:<br> upper = 100;<br> lower = 30;<br> break;<br> case 4:<br> upper = 190;<br> lower = 64;<br> break;<br> case 5:<br> upper = 380;<br> lower = 130;<br> break;<br> case 6:<br> upper = 760;<br> lower = 270;<br> break;<br> case 7:<br> upper = 1500;<br> lower = 540;<br> break;<br> }<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">can we simply implement that by a single table lookup (i. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c">File src/osmo-bts-trx/sched_lchan_xcch.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@63">Patch Set #3, Line 63:</a> <code style="font-family:monospace,monospace">repeated_ul_sacch_active_decision</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Not sure if this file (which is more about mapping, interleaving, and convolutional coding) is the r […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@101">Patch Set #3, Line 101:</a> <code style="font-family:monospace,monospace">talloc_zero_size</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Not really related, but I think we should move memory allocations out of the burst handlers. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Makes sense, but would that increase the performance that much? Allocation happens only once, only the check happens every time - but this does not have to be that way either.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@111">Patch Set #3, Line 111:</a> <code style="font-family:monospace,monospace">*chan_state->ul_bursts_prev</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is wrong, and may lead to NULL-pointer dereference if talloc returns NULL. CR-1.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@178">Patch Set #3, Line 178:</a> <code style="font-family:monospace,monospace">LOGL_NOTICE</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Not sure if this event actually deserves NOTICE. I would drop this logging statement.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@179">Patch Set #3, Line 179:</a> <code style="font-family:monospace,monospace">also yields good data</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">... and this reads really weird. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/3/src/osmo-bts-trx/sched_lchan_xcch.c@192">Patch Set #3, Line 192:</a> <code style="font-family:monospace,monospace">L1SAP_IS_LINK_SACCH(trx_chan_desc[chan].link_id) && lchan->repeated_ul_sacch_active</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I think it makes sense to pre-calculate this condition into a boolean variable, given that you're us […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/osmo-bts-trx/sched_lchan_xcch.c">File src/osmo-bts-trx/sched_lchan_xcch.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/osmo-bts-trx/sched_lchan_xcch.c@37">Patch Set #4, Line 37:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/* Add two arrays of sbits */<br>static void add_sbits(sbit_t *current, const sbit_t *previous)<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">so this is a saturated addition implementation. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I have moved over to the averaged approach. In my experiments I could see that the bit error rate of decoded blocks is slightly increased, but only in the order of one bit of course. I would say there is no difference.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Its probably better to defer this to TNT as I do not know either what the best way is. What I can say is that this method indeed worked, but there may be other methods with better performance of course.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185">change 21185</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21185"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac </div>
<div style="display:none"> Gerrit-Change-Number: 21185 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 28 Nov 2020 21:45:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>