Change in osmo-bts[master]: l1sap: add repeated uplink SACCH

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21185 )

Change subject: l1sap: add repeated uplink SACCH
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/common/l1sap.c 
File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/common/l1sap.c@1420 
PS4, Line 1420: switch (lchan->repeated_acch_capability.rxqual) {
              : 	case 1:
              : 		upper = 26;
              : 		lower = 10;
              : 		break;
              : 	case 2:
              : 		upper = 51;
              : 		lower = 10;
              : 		break;
              : 	case 3:
              : 		upper = 100;
              : 		lower = 30;
              : 		break;
              : 	case 4:
              : 		upper = 190;
              : 		lower = 64;
              : 		break;
              : 	case 5:
              : 		upper = 380;
              : 		lower = 130;
              : 		break;
              : 	case 6:
              : 		upper = 760;
              : 		lower = 270;
              : 		break;
              : 	case 7:
              : 		upper = 1500;
              : 		lower = 540;
              : 		break;
              : 	}
can we simply implement that by a single table lookup (i.e an array indexed by the rxqual value)?  As this function is called quite often, I would guess it makes a difference (single array index lookup vs. a switch statement that ends up with lots of conditionals/branches).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac
Gerrit-Change-Number: 21185
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 26 Nov 2020 10:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201126/46eb44d2/attachment.htm>