<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/common/l1sap.c">File src/common/l1sap.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/common/l1sap.c@1420">Patch Set #4, Line 1420:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">switch (lchan->repeated_acch_capability.rxqual) {<br> case 1:<br>               upper = 26;<br>           lower = 10;<br>           break;<br>        case 2:<br>               upper = 51;<br>           lower = 10;<br>           break;<br>        case 3:<br>               upper = 100;<br>          lower = 30;<br>           break;<br>        case 4:<br>               upper = 190;<br>          lower = 64;<br>           break;<br>        case 5:<br>               upper = 380;<br>          lower = 130;<br>          break;<br>        case 6:<br>               upper = 760;<br>          lower = 270;<br>          break;<br>        case 7:<br>               upper = 1500;<br>         lower = 540;<br>          break;<br>        }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">can we simply implement that by a single table lookup (i.e an array indexed by the rxqual value)?  As this function is called quite often, I would guess it makes a difference (single array index lookup vs. a switch statement that ends up with lots of conditionals/branches).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/21185">change 21185</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/21185"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac </div>
<div style="display:none"> Gerrit-Change-Number: 21185 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 26 Nov 2020 10:14:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>