Change in osmo-bsc[master]: bts: add repeated acch mode flags + vty config

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Nov 20 17:56:05 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21164 )

Change subject: bts: add repeated acch mode flags + vty config
......................................................................


Patch Set 7:

(2 comments)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-bsc/+/21164/6/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/21164/6/include/osmocom/bsc/bts.h@485 
PS6, Line 485: repeated_acch_capability_bts
> what is a bit uncleaer to me is what exactly we are configuring here.   […]
The user is configuring a policy. I agree the name is somewhat misleading, I will find a better name.


https://gerrit.osmocom.org/c/osmo-bsc/+/21164/5/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21164/5/src/osmo-bsc/bsc_vty.c@1121 
PS5, Line 1121: 		vty_out(vty, "  repeat dl-facch cmd%s", VTY_NEWLINE);
> typo: cmd -> command
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190
Gerrit-Change-Number: 21164
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Nov 2020 17:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201120/0f7127c3/attachment.htm>


More information about the gerrit-log mailing list