Change in osmo-bsc[master]: bts: add repeated acch mode flags + vty config

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Nov 20 09:02:56 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21164 )

Change subject: bts: add repeated acch mode flags + vty config
......................................................................


Patch Set 6: -Code-Review

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21164/6/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/21164/6/include/osmocom/bsc/bts.h@485 
PS6, Line 485: repeated_acch_capability_bts
what is a bit uncleaer to me is what exactly we are configuring here.  

Is the user expected to confiure that his BTS is capable of supporting those features?  In that case, this should be automatically detected based on feature flags at OML startup.

Is the user expected to confgure a policy, i.e. that the BSC is permitted to use those feautres if a) the BTS is capable and b) the MS is capable?

The fact that the variable is called "capability_bts" seems to indicate that you are configuring what the BTS is capable of doing.  And that's really something the user shouldn't have to know.  Capabilities of the BTS are reported at OML startup.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190
Gerrit-Change-Number: 21164
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Nov 2020 09:02:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201120/4c74ee54/attachment.htm>


More information about the gerrit-log mailing list