Change in osmo-bsc[master]: handover_test: add test 32: half used TCH/H on dyn TS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Nov 20 08:56:35 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21235 )

Change subject: handover_test: add test 32: half used TCH/H on dyn TS
......................................................................

handover_test: add test 32: half used TCH/H on dyn TS

Shows undesired behavior of moving a TCH/H from a fully used dyn TS
leading to two half-used dyn TS, rather than moving the half-used dyn TS
that would lead to completely freeing a dyn TS.

Change-Id: I3beaa95d12ca0a19d4d1a732f3e22558e68ee29c
---
M tests/handover/handover_test.c
M tests/testsuite.at
2 files changed, 30 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index c9f288f..62c01f0 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -1749,6 +1749,29 @@
 	NULL
 };
 
+static char *test_case_32[] = {
+	"2",
+
+	"Congestion check: favor moving a TCH/H that frees a half-used dyn TS completely\n"
+	,
+	"create-bts", "1", "c+s4", "dyn", "dyn", "dyn", "dyn", "dyn", "-", "-",
+	"set-ts-use", "0", "0",  "*", "PDCH", "TCH/HH", "TCH/H-", "TCH/HH", "PDCH", "-", "-",
+	"meas-rep", "0","0","2","1", "30","0", "0",
+	"meas-rep", "0","0","3","0", "30","0", "0",
+	"meas-rep", "0","0","4","0", "30","0", "0",
+	"meas-rep", "0","0","4","1", "30","0", "0",
+	/* pick one to move */
+	"set-min-free", "0", "TCH/H", "6",
+	"congestion-check",
+	"expect-chan", "0", "1",
+	"ack-chan",
+	/* Not so good: should move the half-used TCH/H instead of "halving" another dyn TS */
+	"expect-ho", "0", "4",
+	"ho-complete",
+	"expect-ts-use", "0", "0",  "*", "TCH/F", "TCH/HH", "TCH/H-", "TCH/H-", "PDCH", "-", "-",
+	NULL
+};
+
 static char **test_cases[] =  {
 	test_case_0,
 	test_case_1,
@@ -1782,6 +1805,7 @@
 	test_case_29,
 	test_case_30,
 	test_case_31,
+	test_case_32,
 };
 
 static const struct log_info_cat log_categories[] = {
diff --git a/tests/testsuite.at b/tests/testsuite.at
index bd6f56f..afff9c5 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -242,3 +242,9 @@
 cat $abs_srcdir/handover/handover_test.ok > expout
 AT_CHECK([$abs_top_builddir/tests/handover/handover_test 31], [], [expout], [ignore])
 AT_CLEANUP
+
+AT_SETUP([handover test 32])
+AT_KEYWORDS([handover])
+cat $abs_srcdir/handover/handover_test.ok > expout
+AT_CHECK([$abs_top_builddir/tests/handover/handover_test 32], [], [expout], [ignore])
+AT_CLEANUP

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21235
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3beaa95d12ca0a19d4d1a732f3e22558e68ee29c
Gerrit-Change-Number: 21235
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201120/09fe82f3/attachment.htm>


More information about the gerrit-log mailing list