<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21235">View Change</a></p><div style="white-space:pre-wrap">Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_test: add test 32: half used TCH/H on dyn TS<br><br>Shows undesired behavior of moving a TCH/H from a fully used dyn TS<br>leading to two half-used dyn TS, rather than moving the half-used dyn TS<br>that would lead to completely freeing a dyn TS.<br><br>Change-Id: I3beaa95d12ca0a19d4d1a732f3e22558e68ee29c<br>---<br>M tests/handover/handover_test.c<br>M tests/testsuite.at<br>2 files changed, 30 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c</span><br><span>index c9f288f..62c01f0 100644</span><br><span>--- a/tests/handover/handover_test.c</span><br><span>+++ b/tests/handover/handover_test.c</span><br><span>@@ -1749,6 +1749,29 @@</span><br><span> NULL</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static char *test_case_32[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ "2",</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ "Congestion check: favor moving a TCH/H that frees a half-used dyn TS completely\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ ,</span><br><span style="color: hsl(120, 100%, 40%);">+ "create-bts", "1", "c+s4", "dyn", "dyn", "dyn", "dyn", "dyn", "-", "-",</span><br><span style="color: hsl(120, 100%, 40%);">+ "set-ts-use", "0", "0", "*", "PDCH", "TCH/HH", "TCH/H-", "TCH/HH", "PDCH", "-", "-",</span><br><span style="color: hsl(120, 100%, 40%);">+ "meas-rep", "0","0","2","1", "30","0", "0",</span><br><span style="color: hsl(120, 100%, 40%);">+ "meas-rep", "0","0","3","0", "30","0", "0",</span><br><span style="color: hsl(120, 100%, 40%);">+ "meas-rep", "0","0","4","0", "30","0", "0",</span><br><span style="color: hsl(120, 100%, 40%);">+ "meas-rep", "0","0","4","1", "30","0", "0",</span><br><span style="color: hsl(120, 100%, 40%);">+ /* pick one to move */</span><br><span style="color: hsl(120, 100%, 40%);">+ "set-min-free", "0", "TCH/H", "6",</span><br><span style="color: hsl(120, 100%, 40%);">+ "congestion-check",</span><br><span style="color: hsl(120, 100%, 40%);">+ "expect-chan", "0", "1",</span><br><span style="color: hsl(120, 100%, 40%);">+ "ack-chan",</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Not so good: should move the half-used TCH/H instead of "halving" another dyn TS */</span><br><span style="color: hsl(120, 100%, 40%);">+ "expect-ho", "0", "4",</span><br><span style="color: hsl(120, 100%, 40%);">+ "ho-complete",</span><br><span style="color: hsl(120, 100%, 40%);">+ "expect-ts-use", "0", "0", "*", "TCH/F", "TCH/HH", "TCH/H-", "TCH/H-", "PDCH", "-", "-",</span><br><span style="color: hsl(120, 100%, 40%);">+ NULL</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static char **test_cases[] = {</span><br><span> test_case_0,</span><br><span> test_case_1,</span><br><span>@@ -1782,6 +1805,7 @@</span><br><span> test_case_29,</span><br><span> test_case_30,</span><br><span> test_case_31,</span><br><span style="color: hsl(120, 100%, 40%);">+ test_case_32,</span><br><span> };</span><br><span> </span><br><span> static const struct log_info_cat log_categories[] = {</span><br><span>diff --git a/tests/testsuite.at b/tests/testsuite.at</span><br><span>index bd6f56f..afff9c5 100644</span><br><span>--- a/tests/testsuite.at</span><br><span>+++ b/tests/testsuite.at</span><br><span>@@ -242,3 +242,9 @@</span><br><span> cat $abs_srcdir/handover/handover_test.ok > expout</span><br><span> AT_CHECK([$abs_top_builddir/tests/handover/handover_test 31], [], [expout], [ignore])</span><br><span> AT_CLEANUP</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+AT_SETUP([handover test 32])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_KEYWORDS([handover])</span><br><span style="color: hsl(120, 100%, 40%);">+cat $abs_srcdir/handover/handover_test.ok > expout</span><br><span style="color: hsl(120, 100%, 40%);">+AT_CHECK([$abs_top_builddir/tests/handover/handover_test 32], [], [expout], [ignore])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_CLEANUP</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21235">change 21235</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21235"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3beaa95d12ca0a19d4d1a732f3e22558e68ee29c </div>
<div style="display:none"> Gerrit-Change-Number: 21235 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>