Change in osmo-bsc[master]: handover_test prep: move generate_si() into create_bts()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21190 )

Change subject: handover_test prep: move generate_si() into create_bts()
......................................................................

handover_test prep: move generate_si() into create_bts()

Preparation for Ic645cea671aa4798804666b8886f11bab5351e11 to allow arbitrary
timeslot configurations in the tests.

Change-Id: I8ed468da53f7b0e5ba8125d1bebafebe8c5becbb
---
M tests/handover/handover_test.c
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index b911b98..cc53386 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -218,6 +218,11 @@
 		osmo_fsm_inst_dispatch(bts->c0->ts[i].fi, TS_EV_RSL_READY, 0);
 		osmo_fsm_inst_dispatch(bts->c0->ts[i].fi, TS_EV_OML_READY, 0);
 	}
+
+	for (i = 0; i < bsc_gsmnet->num_bts; i++) {
+		if (gsm_generate_si(gsm_bts_num(bsc_gsmnet, i), SYSINFO_TYPE_2) <= 0)
+			fprintf(stderr, "Error generating SI2\n");
+	}
 	return bts;
 }
 
@@ -1501,10 +1506,6 @@
 				"TS(1-4) are TCH/F, TS(5-6) are TCH/H)\n", n);
 			for (i = 0; i < n; i++)
 				bts[bts_num + i] = create_bts();
-			for (i = 0; i < n; i++) {
-				if (gsm_generate_si(bts[bts_num + i], SYSINFO_TYPE_2) <= 0)
-					fprintf(stderr, "Error generating SI2\n");
-			}
 			bts_num += n;
 			test_case += 2;
 		} else

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21190
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8ed468da53f7b0e5ba8125d1bebafebe8c5becbb
Gerrit-Change-Number: 21190
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201117/6c26535b/attachment.htm>