<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21190">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_test prep: move generate_si() into create_bts()<br><br>Preparation for Ic645cea671aa4798804666b8886f11bab5351e11 to allow arbitrary<br>timeslot configurations in the tests.<br><br>Change-Id: I8ed468da53f7b0e5ba8125d1bebafebe8c5becbb<br>---<br>M tests/handover/handover_test.c<br>1 file changed, 5 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c</span><br><span>index b911b98..cc53386 100644</span><br><span>--- a/tests/handover/handover_test.c</span><br><span>+++ b/tests/handover/handover_test.c</span><br><span>@@ -218,6 +218,11 @@</span><br><span>                 osmo_fsm_inst_dispatch(bts->c0->ts[i].fi, TS_EV_RSL_READY, 0);</span><br><span>                 osmo_fsm_inst_dispatch(bts->c0->ts[i].fi, TS_EV_OML_READY, 0);</span><br><span>         }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   for (i = 0; i < bsc_gsmnet->num_bts; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+             if (gsm_generate_si(gsm_bts_num(bsc_gsmnet, i), SYSINFO_TYPE_2) <= 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                      fprintf(stderr, "Error generating SI2\n");</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span>    return bts;</span><br><span> }</span><br><span> </span><br><span>@@ -1501,10 +1506,6 @@</span><br><span>                                "TS(1-4) are TCH/F, TS(5-6) are TCH/H)\n", n);</span><br><span>                     for (i = 0; i < n; i++)</span><br><span>                           bts[bts_num + i] = create_bts();</span><br><span style="color: hsl(0, 100%, 40%);">-                        for (i = 0; i < n; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                            if (gsm_generate_si(bts[bts_num + i], SYSINFO_TYPE_2) <= 0)</span><br><span style="color: hsl(0, 100%, 40%);">-                                  fprintf(stderr, "Error generating SI2\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                    }</span><br><span>                    bts_num += n;</span><br><span>                        test_case += 2;</span><br><span>              } else</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/21190">change 21190</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/21190"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8ed468da53f7b0e5ba8125d1bebafebe8c5becbb </div>
<div style="display:none"> Gerrit-Change-Number: 21190 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>