Change in osmo-sgsn[master]: gbproxy: Add todo for BVC RESET logic

[daniel]

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21038 )

Change subject: gbproxy: Add todo for BVC RESET logic
......................................................................

gbproxy: Add todo for BVC RESET logic

When we receive a signalling BVC RESET from the SGSN we want to reset
the signalling BVCs for every peer.

Change-Id: I98c1a53d0e4b9a988e9ddec97ce0c67ded6f6326
Related: SYS#4998
---
M src/gbproxy/gb_proxy.c
M tests/gbproxy/gbproxy_test.ok
2 files changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, approved



diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 2ce7464..e8a81e7 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1218,7 +1218,16 @@
 	case BSSGP_PDUT_BVC_RESET_ACK:
 		if (cfg->route_to_sgsn2 && nsei == cfg->nsip_sgsn2_nsei)
 			break;
-		/* fall through */
+		/* simple case: BVCI IE is mandatory */
+		if (!TLVP_PRESENT(&tp, BSSGP_IE_BVCI))
+			goto err_mand_ie;
+		bvci = ntohs(tlvp_val16_unal(&tp, BSSGP_IE_BVCI));
+		if (bvci == BVCI_SIGNALLING) {
+			/* TODO: Reset all PTP BVCIs */
+		} else {
+			rc = gbprox_relay2bvci(cfg, msg, bvci, ns_bvci);
+		}
+		break;
 	case BSSGP_PDUT_FLUSH_LL:
 		/* simple case: BVCI IE is mandatory */
 		if (!TLVP_PRESENT(&tp, BSSGP_IE_BVCI))
diff --git a/tests/gbproxy/gbproxy_test.ok b/tests/gbproxy/gbproxy_test.ok
index 50c7cd7..6f20f12 100644
--- a/tests/gbproxy/gbproxy_test.ok
+++ b/tests/gbproxy/gbproxy_test.ok
@@ -3236,7 +3236,6 @@
 23 04 82 10 02 
 
 Gbproxy global:
-    Invalid BVC Identifier          : 1
     Patch error: no peer            : 1
 Peers:
   NSEI 4096, BVCI 4098, not blocked, RAI 112-332-16464-96
@@ -4307,7 +4306,6 @@
     Detach Accept count             : 3
     TLLI-Cache: 0
 Gbproxy global:
-    Invalid BVC Identifier          : 1
     BSSGP protocol error      (SGSN): 2
     Patch error: no peer            : 1
 === test_gbproxy_keep_info ===

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21038
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I98c1a53d0e4b9a988e9ddec97ce0c67ded6f6326
Gerrit-Change-Number: 21038
Gerrit-PatchSet: 6
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201106/f3aeb3a6/attachment.htm>