<p>daniel <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21038">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  daniel: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Add todo for BVC RESET logic<br><br>When we receive a signalling BVC RESET from the SGSN we want to reset<br>the signalling BVCs for every peer.<br><br>Change-Id: I98c1a53d0e4b9a988e9ddec97ce0c67ded6f6326<br>Related: SYS#4998<br>---<br>M src/gbproxy/gb_proxy.c<br>M tests/gbproxy/gbproxy_test.ok<br>2 files changed, 10 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c</span><br><span>index 2ce7464..e8a81e7 100644</span><br><span>--- a/src/gbproxy/gb_proxy.c</span><br><span>+++ b/src/gbproxy/gb_proxy.c</span><br><span>@@ -1218,7 +1218,16 @@</span><br><span>     case BSSGP_PDUT_BVC_RESET_ACK:</span><br><span>               if (cfg->route_to_sgsn2 && nsei == cfg->nsip_sgsn2_nsei)</span><br><span>                       break;</span><br><span style="color: hsl(0, 100%, 40%);">-          /* fall through */</span><br><span style="color: hsl(120, 100%, 40%);">+            /* simple case: BVCI IE is mandatory */</span><br><span style="color: hsl(120, 100%, 40%);">+               if (!TLVP_PRESENT(&tp, BSSGP_IE_BVCI))</span><br><span style="color: hsl(120, 100%, 40%);">+                    goto err_mand_ie;</span><br><span style="color: hsl(120, 100%, 40%);">+             bvci = ntohs(tlvp_val16_unal(&tp, BSSGP_IE_BVCI));</span><br><span style="color: hsl(120, 100%, 40%);">+                if (bvci == BVCI_SIGNALLING) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        /* TODO: Reset all PTP BVCIs */</span><br><span style="color: hsl(120, 100%, 40%);">+               } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      rc = gbprox_relay2bvci(cfg, msg, bvci, ns_bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+              }</span><br><span style="color: hsl(120, 100%, 40%);">+             break;</span><br><span>       case BSSGP_PDUT_FLUSH_LL:</span><br><span>            /* simple case: BVCI IE is mandatory */</span><br><span>              if (!TLVP_PRESENT(&tp, BSSGP_IE_BVCI))</span><br><span>diff --git a/tests/gbproxy/gbproxy_test.ok b/tests/gbproxy/gbproxy_test.ok</span><br><span>index 50c7cd7..6f20f12 100644</span><br><span>--- a/tests/gbproxy/gbproxy_test.ok</span><br><span>+++ b/tests/gbproxy/gbproxy_test.ok</span><br><span>@@ -3236,7 +3236,6 @@</span><br><span> 23 04 82 10 02 </span><br><span> </span><br><span> Gbproxy global:</span><br><span style="color: hsl(0, 100%, 40%);">-    Invalid BVC Identifier          : 1</span><br><span>     Patch error: no peer            : 1</span><br><span> Peers:</span><br><span>   NSEI 4096, BVCI 4098, not blocked, RAI 112-332-16464-96</span><br><span>@@ -4307,7 +4306,6 @@</span><br><span>     Detach Accept count             : 3</span><br><span>     TLLI-Cache: 0</span><br><span> Gbproxy global:</span><br><span style="color: hsl(0, 100%, 40%);">-    Invalid BVC Identifier          : 1</span><br><span>     BSSGP protocol error      (SGSN): 2</span><br><span>     Patch error: no peer            : 1</span><br><span> === test_gbproxy_keep_info ===</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21038">change 21038</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/21038"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I98c1a53d0e4b9a988e9ddec97ce0c67ded6f6326 </div>
<div style="display:none"> Gerrit-Change-Number: 21038 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>