Change in osmo-bsc[master]: add fixme comment for OS#3833

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20977 )

Change subject: add fixme comment for OS#3833
......................................................................

add fixme comment for OS#3833

Change-Id: I103d968ffc5e362133fbf017493259048f37e607
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index fde028e..7db37b2 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -492,6 +492,11 @@
 	for (i = 0; i < req->n_ch_mode_rate; i++) {
 		conn->assignment.new_lchan = lchan_select_by_chan_mode(bts,
 		    req->ch_mode_rate[i].chan_mode, req->ch_mode_rate[i].chan_rate);
+		/* FIXME: at this point there is merely an assignment request with a given ch_mode_rate. Writing this to
+		 * conn->lchan->ch_mode_rate is a violation of scopes: the lchan->* state should only be modified
+		 * *after* the assignment is confirmed to be completed. Before that, this data should live in
+		 * conn->assignment or the lchan_activate_info, the designated places for not-yet-confirmed data. See
+		 * OS#3833 */
 		conn->lchan->ch_mode_rate = req->ch_mode_rate[i];
 		if (conn->assignment.new_lchan)
 			break;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20977
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I103d968ffc5e362133fbf017493259048f37e607
Gerrit-Change-Number: 20977
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201102/fb1ab58d/attachment.htm>