<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20977">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add fixme comment for OS#3833<br><br>Change-Id: I103d968ffc5e362133fbf017493259048f37e607<br>---<br>M src/osmo-bsc/assignment_fsm.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c</span><br><span>index fde028e..7db37b2 100644</span><br><span>--- a/src/osmo-bsc/assignment_fsm.c</span><br><span>+++ b/src/osmo-bsc/assignment_fsm.c</span><br><span>@@ -492,6 +492,11 @@</span><br><span>        for (i = 0; i < req->n_ch_mode_rate; i++) {</span><br><span>            conn->assignment.new_lchan = lchan_select_by_chan_mode(bts,</span><br><span>                   req->ch_mode_rate[i].chan_mode, req->ch_mode_rate[i].chan_rate);</span><br><span style="color: hsl(120, 100%, 40%);">+            /* FIXME: at this point there is merely an assignment request with a given ch_mode_rate. Writing this to</span><br><span style="color: hsl(120, 100%, 40%);">+               * conn->lchan->ch_mode_rate is a violation of scopes: the lchan->* state should only be modified</span><br><span style="color: hsl(120, 100%, 40%);">+             * *after* the assignment is confirmed to be completed. Before that, this data should live in</span><br><span style="color: hsl(120, 100%, 40%);">+          * conn->assignment or the lchan_activate_info, the designated places for not-yet-confirmed data. See</span><br><span style="color: hsl(120, 100%, 40%);">+               * OS#3833 */</span><br><span>                conn->lchan->ch_mode_rate = req->ch_mode_rate[i];</span><br><span>           if (conn->assignment.new_lchan)</span><br><span>                   break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/20977">change 20977</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/20977"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I103d968ffc5e362133fbf017493259048f37e607 </div>
<div style="display:none"> Gerrit-Change-Number: 20977 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>