Change in osmo-bsc[master]: abis_nm: only warn about features not supported by the BTS

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18599 )


Change subject: abis_nm: only warn about features not supported by the BTS
......................................................................

abis_nm: only warn about features not supported by the BTS

Change-Id: I2f925bcdb010cb10d074bf7c82619e3ae1f8818b
---
M src/osmo-bsc/abis_nm.c
1 file changed, 7 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/18599/1

diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index 4e01b47..c4c140b 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -589,12 +589,14 @@
 			     "Consider upgrading your BSC/BTS to later version.\n", bts->nr, i);
 		}
 
+		/* Make sure that our local feature set does not contain features that are
+		 * not supported by the BTS we're talking to. It's normal if a BTS reports
+		 * reports features that we considered as not supported though. */
 		for (i = 0; i < _NUM_BTS_FEAT; i++) {
-			if (osmo_bts_has_feature(&bts->features, i) != osmo_bts_has_feature(&bts->model->features, i)) {
-				LOGP(DNM, LOGL_NOTICE, "BTS%u feature '%s' reported via OML does not match statically "
-				     "set feature: %u != %u. Please fix.\n", bts->nr,
-				     get_value_string(osmo_bts_features_descs, i),
-				     osmo_bts_has_feature(&bts->features, i), osmo_bts_has_feature(&bts->model->features, i));
+			if (osmo_bts_has_feature(&bts->features, i) < osmo_bts_has_feature(&bts->model->features, i)) {
+				LOGP(DNM, LOGL_ERROR, "BTS%u Get Attributes Response: reported feature '%s' "
+				     "is not supported, while we thought it is. Please fix.\n",
+				     bts->nr, get_value_string(osmo_bts_features_descs, i));
 			}
 		}
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18599
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2f925bcdb010cb10d074bf7c82619e3ae1f8818b
Gerrit-Change-Number: 18599
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/3ac3877a/attachment.htm>