<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18599">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_nm: only warn about features not supported by the BTS<br><br>Change-Id: I2f925bcdb010cb10d074bf7c82619e3ae1f8818b<br>---<br>M src/osmo-bsc/abis_nm.c<br>1 file changed, 7 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/18599/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index 4e01b47..c4c140b 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -589,12 +589,14 @@</span><br><span>                        "Consider upgrading your BSC/BTS to later version.\n", bts->nr, i);</span><br><span>                }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+         /* Make sure that our local feature set does not contain features that are</span><br><span style="color: hsl(120, 100%, 40%);">+             * not supported by the BTS we're talking to. It's normal if a BTS reports</span><br><span style="color: hsl(120, 100%, 40%);">+             * reports features that we considered as not supported though. */</span><br><span>           for (i = 0; i < _NUM_BTS_FEAT; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        if (osmo_bts_has_feature(&bts->features, i) != osmo_bts_has_feature(&bts->model->features, i)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                               LOGP(DNM, LOGL_NOTICE, "BTS%u feature '%s' reported via OML does not match statically "</span><br><span style="color: hsl(0, 100%, 40%);">-                                    "set feature: %u != %u. Please fix.\n", bts->nr,</span><br><span style="color: hsl(0, 100%, 40%);">-                                   get_value_string(osmo_bts_features_descs, i),</span><br><span style="color: hsl(0, 100%, 40%);">-                                   osmo_bts_has_feature(&bts->features, i), osmo_bts_has_feature(&bts->model->features, i));</span><br><span style="color: hsl(120, 100%, 40%);">+                       if (osmo_bts_has_feature(&bts->features, i) < osmo_bts_has_feature(&bts->model->features, i)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                           LOGP(DNM, LOGL_ERROR, "BTS%u Get Attributes Response: reported feature '%s' "</span><br><span style="color: hsl(120, 100%, 40%);">+                                    "is not supported, while we thought it is. Please fix.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                  bts->nr, get_value_string(osmo_bts_features_descs, i));</span><br><span>                      }</span><br><span>            }</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18599">change 18599</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18599"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2f925bcdb010cb10d074bf7c82619e3ae1f8818b </div>
<div style="display:none"> Gerrit-Change-Number: 18599 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>