Change in osmo-gsm-tester[master]: ms_srs: refactor UE state getter functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Fri May 29 12:03:59 UTC 2020


srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 )

Change subject: ms_srs: refactor UE state getter functions
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/1/src/osmo_gsm_tester/obj/ms_srs.py 
File src/osmo_gsm_tester/obj/ms_srs.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/1/src/osmo_gsm_tester/obj/ms_srs.py@319 
PS1, Line 319:     def is_emm_registered(self):
> Please keep the is_connected() and is_attached() APIs to it also matches the ones in other MS types  […]
I think we can't compare the 2G(/3G) with the 4G/5G case here. The terms are simply different. In 4G/5G we have two different stages too. RRC connected and idle refers to whether the UE has a connection to the eNB. And then EMM registered or deregistered. This refers to whether the UE has a valid "connection" with the core. It's really not the same we need to able to differentiate between the two. We can leave it as attached/connected but it's not clear. And since most of the test cases we write are 4G+ only, it doesn't make sense to stick with an API or terminology that is wrong, does it?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/1/src/osmo_gsm_tester/obj/ms_srs.py@322 
PS1, Line 322:     def get_ipv4_addr(self):
> Please add this API as abstract method in superclass ms.py, and leave it unimplemented in ms_ofono. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I6cd057e34b4df6a1a73695355dd6406d7e039546
Gerrit-Change-Number: 18535
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com>
Gerrit-Comment-Date: Fri, 29 May 2020 12:03:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/bf6b442f/attachment.htm>


More information about the gerrit-log mailing list