This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18563 ) Change subject: PCU: s/f_establish_tbf/f_pcuif_tx_rach_rx_imm_ass/g ...................................................................... PCU: s/f_establish_tbf/f_pcuif_tx_rach_rx_imm_ass/g Fix confusion: f_ms_establish_ul_tbf() vs f_establish_tbf(). The new name precisely describes what the function does. Sending a RACH.ind and receiving a DATA.req with RR Immediate Assignment is just a part of the TBF establishment process. Change-Id: I1e22b9936bf68ebcaf70cefbc57345995ebbbaed --- M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/18563/1 diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 2628938..392440c 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -308,7 +308,7 @@ runs on MS_BTS_IFACE_CT { var GsmRrMessage rr_imm_ass; - rr_imm_ass := f_establish_tbf(ms.ra, ms.ra_is_11bit, ms.burst_type, ms.ta); + rr_imm_ass := f_pcuif_tx_rach_rx_imm_ass(ms.ra, ms.ra_is_11bit, ms.burst_type, ms.ta); ms.ul_tbf := f_ultbf_new_from_rr_imm_ass(rr_imm_ass); } @@ -523,10 +523,10 @@ const BIT8 chan_req_def := '01111000'B; /* Establish an Uplink TBF by sending RACH.ind towards the PCU */ -function f_establish_tbf(uint16_t ra := bit2int(chan_req_def), - uint8_t is_11bit := 0, - PCUIF_BurstType burst_type := BURST_TYPE_0, - TimingAdvance ta := 0) +function f_pcuif_tx_rach_rx_imm_ass(uint16_t ra := bit2int(chan_req_def), + uint8_t is_11bit := 0, + PCUIF_BurstType burst_type := BURST_TYPE_0, + TimingAdvance ta := 0) runs on MS_BTS_IFACE_CT return GsmRrMessage { var uint32_t fn; diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 5fb4b2b..bdcf7c1 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1518,7 +1518,7 @@ ra11 := enc_EGPRSPktChRequest2uint(req); log("Sending EGPRS Packet Channel Request (", ra11, "): ", req); - rr_msg := f_establish_tbf(ra := ra11, is_11bit := 1, burst_type := bt); + rr_msg := f_pcuif_tx_rach_rx_imm_ass(ra := ra11, is_11bit := 1, burst_type := bt); if (not match(rr_msg, t_imm_ass)) { setverdict(fail, "Immediate Assignment does not match"); f_shutdown(__BFILE__, __LINE__); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e22b9936bf68ebcaf70cefbc57345995ebbbaed Gerrit-Change-Number: 18563 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/1cc9a13a/attachment.htm>