<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18563">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">PCU: s/f_establish_tbf/f_pcuif_tx_rach_rx_imm_ass/g<br><br>Fix confusion: f_ms_establish_ul_tbf() vs f_establish_tbf(). The<br>new name precisely describes what the function does. Sending a<br>RACH.ind and receiving a DATA.req with RR Immediate Assignment<br>is just a part of the TBF establishment process.<br><br>Change-Id: I1e22b9936bf68ebcaf70cefbc57345995ebbbaed<br>---<br>M pcu/GPRS_Components.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/18563/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index 2628938..392440c 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -308,7 +308,7 @@</span><br><span> runs on MS_BTS_IFACE_CT {</span><br><span>        var GsmRrMessage rr_imm_ass;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        rr_imm_ass := f_establish_tbf(ms.ra, ms.ra_is_11bit, ms.burst_type, ms.ta);</span><br><span style="color: hsl(120, 100%, 40%);">+   rr_imm_ass := f_pcuif_tx_rach_rx_imm_ass(ms.ra, ms.ra_is_11bit, ms.burst_type, ms.ta);</span><br><span>       ms.ul_tbf := f_ultbf_new_from_rr_imm_ass(rr_imm_ass);</span><br><span> }</span><br><span> </span><br><span>@@ -523,10 +523,10 @@</span><br><span> const BIT8 chan_req_def := '01111000'B;</span><br><span> </span><br><span> /* Establish an Uplink TBF by sending RACH.ind towards the PCU */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_establish_tbf(uint16_t ra := bit2int(chan_req_def),</span><br><span style="color: hsl(0, 100%, 40%);">-                         uint8_t is_11bit := 0,</span><br><span style="color: hsl(0, 100%, 40%);">-                  PCUIF_BurstType burst_type := BURST_TYPE_0,</span><br><span style="color: hsl(0, 100%, 40%);">-                     TimingAdvance ta := 0)</span><br><span style="color: hsl(120, 100%, 40%);">+function f_pcuif_tx_rach_rx_imm_ass(uint16_t ra := bit2int(chan_req_def),</span><br><span style="color: hsl(120, 100%, 40%);">+                                uint8_t is_11bit := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+                                PCUIF_BurstType burst_type := BURST_TYPE_0,</span><br><span style="color: hsl(120, 100%, 40%);">+                                   TimingAdvance ta := 0)</span><br><span> runs on MS_BTS_IFACE_CT return GsmRrMessage {</span><br><span>  var uint32_t fn;</span><br><span> </span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 5fb4b2b..bdcf7c1 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -1518,7 +1518,7 @@</span><br><span>    ra11 := enc_EGPRSPktChRequest2uint(req);</span><br><span>     log("Sending EGPRS Packet Channel Request (", ra11, "): ", req);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        rr_msg := f_establish_tbf(ra := ra11, is_11bit := 1, burst_type := bt);</span><br><span style="color: hsl(120, 100%, 40%);">+       rr_msg := f_pcuif_tx_rach_rx_imm_ass(ra := ra11, is_11bit := 1, burst_type := bt);</span><br><span>   if (not match(rr_msg, t_imm_ass)) {</span><br><span>          setverdict(fail, "Immediate Assignment does not match");</span><br><span>           f_shutdown(__BFILE__, __LINE__);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18563">change 18563</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18563"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1e22b9936bf68ebcaf70cefbc57345995ebbbaed </div>
<div style="display:none"> Gerrit-Change-Number: 18563 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>