This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539 ) Change subject: 4g_suite: add MT and MO test cases ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_originated_traffic.py File sysmocom/suites/4g/mobile_originated_traffic.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_originated_traffic.py@1 PS1, Line 1: #!/usr/bin/env python3 What about naming this test "mo_idle_ping" ? It looks much more clear to me what it does at a single glance. BTW, feel free in general to add some comments at the start of the test if you want, explaining what main aim of the test. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_originated_traffic.py@23 PS1, Line 23: wait(ue.is_rrc_idle) so this is basically "not ue.is_rrc_connected" right? I'd avoid having this API for sake of maintenance burden for all MS classes. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_terminated_traffic.py File sysmocom/suites/4g/mobile_terminated_traffic.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_terminated_traffic.py@1 PS1, Line 1: #!/usr/bin/env python3 Name it "mt_idle_ping.py" ? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I5c7639f2c6953964a5b6979bc35f59464dbda43f Gerrit-Change-Number: 18539 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre <andre at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 28 May 2020 11:40:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200528/2f8b1acd/attachment.htm>