<p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_originated_traffic.py">File sysmocom/suites/4g/mobile_originated_traffic.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_originated_traffic.py@1">Patch Set #1, Line 1:</a> <code style="font-family:monospace,monospace">#!/usr/bin/env python3</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What about naming this test "mo_idle_ping" ? It looks much more clear to me what it does at a single glance.<br>BTW, feel free in general to add some comments at the start of the test if you want, explaining what main aim of the test.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_originated_traffic.py@23">Patch Set #1, Line 23:</a> <code style="font-family:monospace,monospace">wait(ue.is_rrc_idle)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">so this is basically "not ue.is_rrc_connected" right? I'd avoid having this API for sake of maintenance burden for all MS classes.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_terminated_traffic.py">File sysmocom/suites/4g/mobile_terminated_traffic.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539/1/sysmocom/suites/4g/mobile_terminated_traffic.py@1">Patch Set #1, Line 1:</a> <code style="font-family:monospace,monospace">#!/usr/bin/env python3</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Name it "mt_idle_ping.py" ?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539">change 18539</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18539"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gsm-tester </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5c7639f2c6953964a5b6979bc35f59464dbda43f </div>
<div style="display:none"> Gerrit-Change-Number: 18539 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: srs_andre <andre@softwareradiosystems.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 28 May 2020 11:40:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>