This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 ) Change subject: refactor bsc_find_msc()'s round-robin ...................................................................... Patch Set 3: (3 comments) AS I said, I'd rather implement the roundrobin by keeping a pointer to last/next msc's llisthead. Since we have and use llists here, let's use their benefits. https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/include/osmocom/bsc/gsm_data.h@1652 PS3, Line 1652: uint8_t mscs_round_robin_next_nr; What about using point to last/next llist_head? https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/src/osmo-bsc/gsm_08_08.c File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/src/osmo-bsc/gsm_08_08.c@111 PS3, Line 111: static bool is_cm_service_for_emerg(struct msgb *msg) Please next time submit this kind of changes as a separate commit. https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/src/osmo-bsc/gsm_08_08.c@249 PS3, Line 249: net->mscs_round_robin_next_nr = msc_target->nr + 1; Is this number ever decreased? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291 Gerrit-Change-Number: 18505 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 28 May 2020 09:53:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200528/005608ab/attachment.htm>