<p style="white-space: pre-wrap; word-wrap: break-word;">AS I said, I'd rather implement the roundrobin by keeping a pointer to last/next msc's llisthead. Since we have and use llists here, let's use their benefits.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18505">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/include/osmocom/bsc/gsm_data.h">File include/osmocom/bsc/gsm_data.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/include/osmocom/bsc/gsm_data.h@1652">Patch Set #3, Line 1652:</a> <code style="font-family:monospace,monospace">  uint8_t mscs_round_robin_next_nr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What about using point to last/next llist_head?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/src/osmo-bsc/gsm_08_08.c">File src/osmo-bsc/gsm_08_08.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/src/osmo-bsc/gsm_08_08.c@111">Patch Set #3, Line 111:</a> <code style="font-family:monospace,monospace">static bool is_cm_service_for_emerg(struct msgb *msg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Please next time submit this kind of changes as a separate commit.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18505/3/src/osmo-bsc/gsm_08_08.c@249">Patch Set #3, Line 249:</a> <code style="font-family:monospace,monospace">          net->mscs_round_robin_next_nr = msc_target->nr + 1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this number ever decreased?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18505">change 18505</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18505"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291 </div>
<div style="display:none"> Gerrit-Change-Number: 18505 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 28 May 2020 09:53:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>