This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
ipse gerrit-no-reply at lists.osmocom.orgipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18439 ) Change subject: log: Don't log an ERROR on forwarding message to a closed SCCP link. ...................................................................... log: Don't log an ERROR on forwarding message to a closed SCCP link. Message processing here can fail for several reasons not all of which are actually ERRORs. If the processing has failed because we can't decode the message or have some internal problem, it deserves an ERROR log. But if it fails simply because MSC has alreday shut down the SCCP connection, it is a normal flow and should be INFO at max. E.g. we observed, that we very often get Classmark Change message from a phone right after the MSC has shut the SCCP connection but before we close the lchan on the BTS. Change-Id: I7af0da70185a86e10737d93001fb9352dbd233ec --- M src/input/ipaccess.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/39/18439/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index e1936af..57b53b3 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -390,8 +390,13 @@ * an error, that's too strict. BTW, the signalling layer is * resposible for releasing the message. */ - LOGP(DLINP, LOGL_ERROR, "Bad signalling message," - " sign_link returned error: %s.\n", strerror(-rc)); + if (rc == -ENOTCONN) + LOGP(DLINP, LOGL_INFO, "Remote connection is already closed, discarding the message: %s\n", + osmo_hexdump(msgb_l2(msg), msgb_l2len(msg))); + else + LOGP(DLINP, LOGL_ERROR, "Bad signalling message," + " sign_link returned error: %s. Msg: %s\n", + strerror(-rc), osmo_hexdump(msgb_l2(msg), msgb_l2len(msg))); } return rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7af0da70185a86e10737d93001fb9352dbd233ec Gerrit-Change-Number: 18439 Gerrit-PatchSet: 1 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200524/997dc7b1/attachment.htm>