<p>ipse has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/18439">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">log: Don't log an ERROR on forwarding message to a closed SCCP link.<br><br>Message processing here can fail for several reasons not all of which<br>are actually ERRORs. If the processing has failed because we can't<br>decode the message or have some internal problem, it deserves an ERROR<br>log. But if it fails simply because MSC has alreday shut down the SCCP<br>connection, it is a normal flow and should be INFO at max.<br><br>E.g. we observed, that we very often get Classmark Change message<br>from a phone right after the MSC has shut the SCCP connection but<br>before we close the lchan on the BTS.<br><br>Change-Id: I7af0da70185a86e10737d93001fb9352dbd233ec<br>---<br>M src/input/ipaccess.c<br>1 file changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/39/18439/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index e1936af..57b53b3 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -390,8 +390,13 @@</span><br><span>                * an error, that's too strict. BTW, the signalling layer is</span><br><span>              * resposible for releasing the message.</span><br><span>              */</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGP(DLINP, LOGL_ERROR, "Bad signalling message,"</span><br><span style="color: hsl(0, 100%, 40%);">-                  " sign_link returned error: %s.\n", strerror(-rc));</span><br><span style="color: hsl(120, 100%, 40%);">+            if (rc == -ENOTCONN)</span><br><span style="color: hsl(120, 100%, 40%);">+                  LOGP(DLINP, LOGL_INFO, "Remote connection is already closed, discarding the message: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                      osmo_hexdump(msgb_l2(msg), msgb_l2len(msg)));</span><br><span style="color: hsl(120, 100%, 40%);">+            else</span><br><span style="color: hsl(120, 100%, 40%);">+                  LOGP(DLINP, LOGL_ERROR, "Bad signalling message,"</span><br><span style="color: hsl(120, 100%, 40%);">+                        " sign_link returned error: %s. Msg: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                         strerror(-rc), osmo_hexdump(msgb_l2(msg), msgb_l2len(msg)));</span><br><span>    }</span><br><span> </span><br><span>        return rc;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/18439">change 18439</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/18439"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7af0da70185a86e10737d93001fb9352dbd233ec </div>
<div style="display:none"> Gerrit-Change-Number: 18439 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>