Change in osmo-bsc[master]: stats: Add a BTS counter for paging rqsts responded elsewhere.

[ipse]

ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18426 )


Change subject: stats: Add a BTS counter for paging rqsts responded elsewhere.
......................................................................

stats: Add a BTS counter for paging rqsts responded elsewhere.

If we have several BTS in a single LAC, only one of them will respond
to the paging. Without this counter this situation will lead to
"lost" paging requests, i.e. in disparity between attempted pagings
and expired/responded/etc pagings. Now the sum of all paging
response counters should actually match the attempted counter.

Change-Id: I4b27a0559ef2762e62bc3ac30000f17b89b0ed48
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/paging.c
2 files changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/18426/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index a2e103d..38df1dc 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1411,6 +1411,7 @@
 	BTS_CTR_PAGING_ATTEMPTED,
 	BTS_CTR_PAGING_ALREADY,
 	BTS_CTR_PAGING_RESPONDED,
+	BTS_CTR_PAGING_RESPONDED_ELSEWHERE,
 	BTS_CTR_PAGING_EXPIRED,
 	BTS_CTR_PAGING_NO_ACTIVE_PAGING,
 	BTS_CTR_CHAN_ACT_TOTAL,
@@ -1457,6 +1458,7 @@
 	[BTS_CTR_PAGING_ATTEMPTED] = 		{"paging:attempted", "Paging attempts for a subscriber."},
 	[BTS_CTR_PAGING_ALREADY] = 		{"paging:already", "Paging attempts ignored as subscriber was already being paged."},
 	[BTS_CTR_PAGING_RESPONDED] = 		{"paging:responded", "Paging attempts with successful paging response."},
+	[BTS_CTR_PAGING_RESPONDED_ELSEWHERE] =	{"paging:responded_elsewhere", "Paging attempts with paging response received on another BTS with the same LAC."},
 	[BTS_CTR_PAGING_EXPIRED] = 		{"paging:expired", "Paging Request expired because of timeout T3113."},
 	[BTS_CTR_PAGING_NO_ACTIVE_PAGING] =	{"paging:no_active_paging", "Paging response without an active paging request (arrived after paging expiration?)."},
 	[BTS_CTR_CHAN_ACT_TOTAL] =		{"chan_act:total", "Total number of Channel Activations."},
diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c
index d32cded..3da6ecc 100644
--- a/src/osmo-bsc/paging.c
+++ b/src/osmo-bsc/paging.c
@@ -441,7 +441,9 @@
 		/* Sort of an optimization. */
 		if (bts == _bts)
 			continue;
-		_paging_request_stop(bts, bsub, NULL, NULL);
+		if (_paging_request_stop(bts, bsub, NULL, NULL)) {
+			rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_RESPONDED_ELSEWHERE]);
+		}
 	}
 	log_set_context(LOG_CTX_BSC_SUBSCR, NULL);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18426
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4b27a0559ef2762e62bc3ac30000f17b89b0ed48
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200522/b300810d/attachment.htm>