<p>ipse has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18426">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stats: Add a BTS counter for paging rqsts responded elsewhere.<br><br>If we have several BTS in a single LAC, only one of them will respond<br>to the paging. Without this counter this situation will lead to<br>"lost" paging requests, i.e. in disparity between attempted pagings<br>and expired/responded/etc pagings. Now the sum of all paging<br>response counters should actually match the attempted counter.<br><br>Change-Id: I4b27a0559ef2762e62bc3ac30000f17b89b0ed48<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/paging.c<br>2 files changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/18426/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index a2e103d..38df1dc 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -1411,6 +1411,7 @@</span><br><span>  BTS_CTR_PAGING_ATTEMPTED,</span><br><span>    BTS_CTR_PAGING_ALREADY,</span><br><span>      BTS_CTR_PAGING_RESPONDED,</span><br><span style="color: hsl(120, 100%, 40%);">+     BTS_CTR_PAGING_RESPONDED_ELSEWHERE,</span><br><span>  BTS_CTR_PAGING_EXPIRED,</span><br><span>      BTS_CTR_PAGING_NO_ACTIVE_PAGING,</span><br><span>     BTS_CTR_CHAN_ACT_TOTAL,</span><br><span>@@ -1457,6 +1458,7 @@</span><br><span>      [BTS_CTR_PAGING_ATTEMPTED] =            {"paging:attempted", "Paging attempts for a subscriber."},</span><br><span>       [BTS_CTR_PAGING_ALREADY] =              {"paging:already", "Paging attempts ignored as subscriber was already being paged."},</span><br><span>    [BTS_CTR_PAGING_RESPONDED] =            {"paging:responded", "Paging attempts with successful paging response."},</span><br><span style="color: hsl(120, 100%, 40%);">+ [BTS_CTR_PAGING_RESPONDED_ELSEWHERE] =  {"paging:responded_elsewhere", "Paging attempts with paging response received on another BTS with the same LAC."},</span><br><span>       [BTS_CTR_PAGING_EXPIRED] =              {"paging:expired", "Paging Request expired because of timeout T3113."},</span><br><span>  [BTS_CTR_PAGING_NO_ACTIVE_PAGING] =     {"paging:no_active_paging", "Paging response without an active paging request (arrived after paging expiration?)."},</span><br><span>     [BTS_CTR_CHAN_ACT_TOTAL] =              {"chan_act:total", "Total number of Channel Activations."},</span><br><span>diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c</span><br><span>index d32cded..3da6ecc 100644</span><br><span>--- a/src/osmo-bsc/paging.c</span><br><span>+++ b/src/osmo-bsc/paging.c</span><br><span>@@ -441,7 +441,9 @@</span><br><span>               /* Sort of an optimization. */</span><br><span>               if (bts == _bts)</span><br><span>                     continue;</span><br><span style="color: hsl(0, 100%, 40%);">-               _paging_request_stop(bts, bsub, NULL, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+          if (_paging_request_stop(bts, bsub, NULL, NULL)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_RESPONDED_ELSEWHERE]);</span><br><span style="color: hsl(120, 100%, 40%);">+              }</span><br><span>    }</span><br><span>    log_set_context(LOG_CTX_BSC_SUBSCR, NULL);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18426">change 18426</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18426"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4b27a0559ef2762e62bc3ac30000f17b89b0ed48 </div>
<div style="display:none"> Gerrit-Change-Number: 18426 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>