Change in osmo-ttcn3-hacks[master]: WIP: Fix TC_egprs_pkt_chan_req* tests

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18371 )


Change subject: WIP: Fix TC_egprs_pkt_chan_req* tests
......................................................................

WIP: Fix TC_egprs_pkt_chan_req* tests

Somehow after refactoring these 3 tests became broken. I think it's
because before the refactoring, a bug was present in f_establish_tbf
which set it always to 127 no matter what was passed (which looks wrong
from these tests point of view).
So apparently I fixed a part of the infrastructure, and now tests fail
because other parts of the infrastructure (also old ones) do not support
this kind of scenarios.

Change-Id: I690ede0667a574892dcd93b941003054182c8e39
---
M pcu/GPRS_Components.ttcn
1 file changed, 9 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/18371/1

diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index 8d47d44..f845c14 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -146,7 +146,8 @@
 		log("Rx Uplink TBF assignment: ", ul_tbf.ass);
 		setverdict(pass);
 	} else {
-		setverdict(fail, "Failed to match UL TBF Assignment");
+		setverdict(fail, "Failed to match UL TBF Assignment: ", rr_imm_ass,
+			   " vs exp ", tr_IMM_TBF_ASS(dl := false, rest := tr_IaRestOctets_ULAss(?)));
 		f_shutdown(__BFILE__, __LINE__);
 	}
 
@@ -327,9 +328,15 @@
 				   fn := fn, arfcn := 871,
 				   qta := ms.ta * 4));
 
+	/* TODO: tr_IMM_TBF_ASS(false, ms.ra, fn) fails for 11bit, because
+	 *  tr_compute_ReqRef() doens't support 11bit:
+	 * GSM_RR_Types.ttcn:345
+	 * Dynamic test case error: The first argument of function int2bit(),
+	 * which is 1661, does not fit in 8 bits, needs at least 11. */
+
 	/* Expect Immediate (TBF) Assignment on TS0/AGCH */
 	rr_imm_ass := f_ms_rx_imm_ass_ccch(ms, PCU_IF_SAPI_AGCH,
-	                                   tr_IMM_TBF_ASS(false, ms.ra, fn));
+	                                   tr_IMM_TBF_ASS(false, ?, fn));
 
 	ms.ul_tbf := f_ultbf_new_from_rr_imm_ass(rr_imm_ass);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18371
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I690ede0667a574892dcd93b941003054182c8e39
Gerrit-Change-Number: 18371
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200519/168592f6/attachment.htm>