<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18371">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">WIP: Fix TC_egprs_pkt_chan_req* tests<br><br>Somehow after refactoring these 3 tests became broken. I think it's<br>because before the refactoring, a bug was present in f_establish_tbf<br>which set it always to 127 no matter what was passed (which looks wrong<br>from these tests point of view).<br>So apparently I fixed a part of the infrastructure, and now tests fail<br>because other parts of the infrastructure (also old ones) do not support<br>this kind of scenarios.<br><br>Change-Id: I690ede0667a574892dcd93b941003054182c8e39<br>---<br>M pcu/GPRS_Components.ttcn<br>1 file changed, 9 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/18371/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index 8d47d44..f845c14 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -146,7 +146,8 @@</span><br><span>          log("Rx Uplink TBF assignment: ", ul_tbf.ass);</span><br><span>             setverdict(pass);</span><br><span>    } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                setverdict(fail, "Failed to match UL TBF Assignment");</span><br><span style="color: hsl(120, 100%, 40%);">+              setverdict(fail, "Failed to match UL TBF Assignment: ", rr_imm_ass,</span><br><span style="color: hsl(120, 100%, 40%);">+                    " vs exp ", tr_IMM_TBF_ASS(dl := false, rest := tr_IaRestOctets_ULAss(?)));</span><br><span>             f_shutdown(__BFILE__, __LINE__);</span><br><span>     }</span><br><span> </span><br><span>@@ -327,9 +328,15 @@</span><br><span>                                    fn := fn, arfcn := 871,</span><br><span>                              qta := ms.ta * 4));</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    /* TODO: tr_IMM_TBF_ASS(false, ms.ra, fn) fails for 11bit, because</span><br><span style="color: hsl(120, 100%, 40%);">+     *  tr_compute_ReqRef() doens't support 11bit:</span><br><span style="color: hsl(120, 100%, 40%);">+     * GSM_RR_Types.ttcn:345</span><br><span style="color: hsl(120, 100%, 40%);">+       * Dynamic test case error: The first argument of function int2bit(),</span><br><span style="color: hsl(120, 100%, 40%);">+  * which is 1661, does not fit in 8 bits, needs at least 11. */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    /* Expect Immediate (TBF) Assignment on TS0/AGCH */</span><br><span>  rr_imm_ass := f_ms_rx_imm_ass_ccch(ms, PCU_IF_SAPI_AGCH,</span><br><span style="color: hsl(0, 100%, 40%);">-                                           tr_IMM_TBF_ASS(false, ms.ra, fn));</span><br><span style="color: hsl(120, 100%, 40%);">+                                    tr_IMM_TBF_ASS(false, ?, fn));</span><br><span> </span><br><span>        ms.ul_tbf := f_ultbf_new_from_rr_imm_ass(rr_imm_ass);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18371">change 18371</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18371"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I690ede0667a574892dcd93b941003054182c8e39 </div>
<div style="display:none"> Gerrit-Change-Number: 18371 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>