Change in osmo-bsc[master]: stats: Export connected OML/RSL links count per BTS.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri May 8 16:18:26 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18093 )

Change subject: stats: Export connected OML/RSL links count per BTS.
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/18093/6/src/osmo-bsc/bts_ipaccess_nanobts.c 
File src/osmo-bsc/bts_ipaccess_nanobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18093/6/src/osmo-bsc/bts_ipaccess_nanobts.c@400 
PS6, Line 400: 	osm
specifically here is a problem. Just because on RSL connection (= TRX in most cases) disconnected, doesn't mean that all of them are gone.  You'd have to actuall subtract the count by one, not set it to zero.


https://gerrit.osmocom.org/c/osmo-bsc/+/18093/6/src/osmo-bsc/bts_ipaccess_nanobts.c@591 
PS6, Line 591: 		osm
equally here, you'd have to increment, not set to one.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18093
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I88c8025940a0eecb034b1c70f76ea17937fa0325
Gerrit-Change-Number: 18093
Gerrit-PatchSet: 6
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 May 2020 16:18:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/8b9e5780/attachment.htm>


More information about the gerrit-log mailing list