<p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18093">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18093/6/src/osmo-bsc/bts_ipaccess_nanobts.c">File src/osmo-bsc/bts_ipaccess_nanobts.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18093/6/src/osmo-bsc/bts_ipaccess_nanobts.c@400">Patch Set #6, Line 400:</a> <code style="font-family:monospace,monospace">  osm</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">specifically here is a problem. Just because on RSL connection (= TRX in most cases) disconnected, doesn't mean that all of them are gone.  You'd have to actuall subtract the count by one, not set it to zero.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18093/6/src/osmo-bsc/bts_ipaccess_nanobts.c@591">Patch Set #6, Line 591:</a> <code style="font-family:monospace,monospace">           osm</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">equally here, you'd have to increment, not set to one.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18093">change 18093</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18093"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I88c8025940a0eecb034b1c70f76ea17937fa0325 </div>
<div style="display:none"> Gerrit-Change-Number: 18093 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 08 May 2020 16:18:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>