This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
ipse gerrit-no-reply at lists.osmocom.orgipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18090 ) Change subject: ctrs: Correctly count load total for dynamic timeslots. ...................................................................... Patch Set 1: (4 comments) > So the idea behind this commit is that dynamic timeslosts should count when calculating total available load, even if they are at pdch at that moment, because they can be turned to TCH at any time when required. Am I correct? please describe something like that in the commit message. Yes, correct - see the updated comments in the new patch. From the CS perspective, there is no difference whether this is a dynamic TS in NONE/PDCH mode or a static TCH in UNUSED mode since BSC can switch into USED mode at any moment. https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c File src/osmo-bsc/chan_alloc.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c@40 PS1, Line 40: void bts_chan_load(struct pchan_load *cl, const struct gsm_bts *bts) > would be great having documentation for this function... I'll commit a one-liner in a separate commit. https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c@63 PS1, Line 63: * have an lchan's allocated to them */ > "an lchan allocated" Ack https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c@66 PS1, Line 66: && ( ts->pchan_is == GSM_PCHAN_NONE > please fix whitespace in all this if condition. I'm not completely sure of the Osmocom rules for the muli-line whitespace but I've changed this to look closer to what I see around in the next revision of this patch. https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c@72 PS1, Line 72: * Note: When GSM_PCHAN_TCH_F_TCH_H_PDCH is allocation > "is allocation in" doesn't make sense to me, please fix. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iabd70e8adbf15eb3b7a7be597281ea99b352317b Gerrit-Change-Number: 18090 Gerrit-PatchSet: 1 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 07 May 2020 12:36:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200507/5e9c26bc/attachment.htm>